-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support response header filter for GRPCRoute #1983
Support response header filter for GRPCRoute #1983
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1983 +/- ##
==========================================
+ Coverage 86.90% 86.92% +0.01%
==========================================
Files 88 88
Lines 6056 6064 +8
Branches 50 50
==========================================
+ Hits 5263 5271 +8
Misses 741 741
Partials 52 52 ☔ View full report in Codecov by Sentry. |
7afe38a
to
66bd9f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM docs-wise!
👍 |
66bd9f7
to
f0e75dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
f0e75dc
to
556c8c7
Compare
Proposed changes
Problem: As a user, I want to be able to add ResponseHeaderModifier filter for my GRPCRoutes.
Solution: Add support for ResponseHeaderModifier filter for my GRPCRoutes. The implementation reuses validation and logic from the HTTPRoute implementation. This PR also removes some redundant empty structs in the servers_test.go
Testing: The functionality is identical to HTTPRoute so not much additional testing is required. I tested locally using echo server and grpcurl. I didn't modify the application to configure headers on the upstream side, but we can see the response headers set in the GRPCRoute spec have been returned:
Closes #1935
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.