Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nginx-bot in NFR PR #1728

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Use nginx-bot in NFR PR #1728

merged 1 commit into from
Mar 19, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Mar 19, 2024 •
edited
Loading

Proposed changes

Problem: GitHub won't run Actions for commits created by a bot using the default token

Solution: Use nginx-bot (that is not actually a bot) with a PAT.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome
Use nginx-bot in NFR PR
b873eba 
Problem: GitHub won't run Actions for commits created by a bot using the
default token

Solution: Use nginx-bot (that is not actually a bot) with a PAT.
@lucacome lucacome requested a review from a team as a code owner March 19, 2024 20:36
@github-actions github-actions bot added the chore Pull requests for routine tasks label Mar 19, 2024
@lucacome lucacome enabled auto-merge (squash) March 19, 2024 20:44
@lucacome lucacome merged commit 5b9f37c into nginx:main Mar 19, 2024
40 checks passed
@lucacome lucacome deleted the chore/use-nginx-bot branch March 19, 2024 20:49
amimimor pushed a commit to amimimor/nginx-gateway-fabric that referenced this pull request Apr 3, 2024
@lucacome @amimimor
Use nginx-bot in NFR PR (nginx#1728)
450b59c 
Problem: GitHub won't run Actions for commits created by a bot using the
default token

Solution: Use nginx-bot (that is not actually a bot) with a PAT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@pleshakov pleshakov pleshakov approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacome @pleshakov @sjberman