Update PR step in NFR workflow #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarams87
changed the title
kate-osborn
approved these changes
Mar 7, 2024
sjberman
approved these changes
Mar 7, 2024
ciarams87
force-pushed
the
chore/update-nfr-workflow
branch
from
1ec9394 to
72f31c4
Compare
amimimor
pushed a commit
to amimimor/nginx-gateway-fabric
that referenced
this pull request
Apr 3, 2024
Gitignore GHA creds file; update PR workflow step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The PR that is automatically being opened by the NFR workflow contains more than just the results files.
Solution: Only add the files under the tests/results folder to the PR. Also add GitHub actions credentials files to gitignore.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.