Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotations for Artifact Hub #1554

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Feb 8, 2024

Proposed changes

Problem: The image is not scanning correctly on Artifact Hub because of the missing annotations in the OCI manifest.

Solution: Add the required annotations and some optional ones to improve the listing.

This also uploads the SBOMs to GitHub in addition to the Sarif.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@lucacome lucacome self-assigned this Feb 8, 2024
@lucacome lucacome requested a review from a team as a code owner February 8, 2024 23:39
@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 8, 2024
Problem: The image is not scanning correctly on Artifact Hub because of
the missing annotations in the OCI manifest.

Solution: Add the required annotations and some optional ones to improve
the listing.

This also uploads the SBOMs to GitHub in addition to the Sarif.
@lucacome lucacome enabled auto-merge (squash) February 9, 2024 20:52
@lucacome lucacome merged commit e6be24e into nginx:main Feb 9, 2024
30 checks passed
@lucacome lucacome deleted the chore/artifatcs branch April 1, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants