Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the right parameter for milestones #1542

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Feb 6, 2024

Proposed changes

Problem: exempt-issue-milestones takes a list of milestones to exclude.

Solution: exempt-all-issue-milestones excludes issues that have any milestones attached.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Problem: `exempt-issue-milestones` takes a list of milestones to
exclude.

Solution: `exempt-all-issue-milestones` excludes issues that have any milestones
attached.
@lucacome lucacome requested a review from a team as a code owner February 6, 2024 05:56
@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 6, 2024
@lucacome lucacome enabled auto-merge (squash) February 6, 2024 16:28
@lucacome lucacome merged commit 08ba0c4 into nginx:main Feb 6, 2024
27 checks passed
@lucacome lucacome deleted the chore/fix-stale branch April 1, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants