-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NGINX plus Dockerfile, add make command, add metrics #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
dependencies
Pull requests that update a dependency file
helm-chart
Relates to helm chart
labels
Dec 15, 2023
kate-osborn
requested changes
Dec 15, 2023
sjberman
reviewed
Dec 15, 2023
pleshakov
suggested changes
Dec 15, 2023
ciarams87
force-pushed
the
feat/support-nginx-plus
branch
from
December 18, 2023 16:51
1db79b2
to
46a7968
Compare
kate-osborn
requested changes
Dec 18, 2023
pleshakov
approved these changes
Dec 18, 2023
sjberman
approved these changes
Dec 18, 2023
bjee19
requested changes
Dec 18, 2023
ciarams87
force-pushed
the
feat/support-nginx-plus
branch
from
December 19, 2023 09:36
46a7968
to
a520637
Compare
kate-osborn
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
bjee19
approved these changes
Dec 19, 2023
ciarams87
force-pushed
the
feat/support-nginx-plus
branch
from
December 19, 2023 17:05
a520637
to
dfeaaf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request
helm-chart
Relates to helm chart
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: To enable support for NGINX Plus we need a way to build NGINX Plus images using a provided license. Additionally, if we are using an NGINX Plus image, we need to update the Prometheus exporter to use the NGINX Plus API instead of the stub_status so we do not get errors when metrics are enabled.
Solution:
Testing: Built and deployed the NGINX Plus image as part of my NGF deployment locally and ran the examples
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #1327
Closes #1330
Checklist
Before creating a PR, run through this checklist and mark each as complete.