Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional Test for Telemetry Exporter Integration #1640

Closed
mpstefan opened this issue Mar 6, 2024 · 1 comment
Closed

Functional Test for Telemetry Exporter Integration #1640

mpstefan opened this issue Mar 6, 2024 · 1 comment
Assignees
@pleshakov
Labels
refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week tests Pull requests that update tests
Milestone
v1.2.0

Comments

@mpstefan
Copy link
Collaborator

mpstefan commented Mar 6, 2024 •
edited
Loading

As a maintainer of NGF
I want a functional test to cover the Telemetry Exporter integration in the NGF project
So that I can ensure that this feature is not regressed in the future.

Acceptance

  • Write a functional test that verifies that the NGF collection job sends data to the telemetry exporter every time data is collected, using local collector.
@mpstefan mpstefan added tests Pull requests that update tests refined Requirements are refined and the issue is ready to be implemented. labels Mar 6, 2024
@mpstefan mpstefan added this to the v1.2.0 milestone Mar 6, 2024
@mpstefan mpstefan added size/medium Estimated to be completed within a week blocked Blocked by other issue labels Mar 6, 2024
@mpstefan
Copy link
Collaborator Author

mpstefan commented Mar 6, 2024 •
edited
Loading

Blocked by #1377

@pleshakov pleshakov removed the blocked Blocked by other issue label Mar 7, 2024
@pleshakov pleshakov mentioned this issue Mar 7, 2024
Closed
@pleshakov pleshakov self-assigned this Mar 7, 2024
pleshakov added a commit to pleshakov/nginx-gateway-fabric that referenced this issue Mar 8, 2024
@pleshakov
Add functional test for product telemetry
3a29904 
Problem:
Ensure product telemetry feature is tested with a functional test

Solution:
- Add a functional test.
- Because it requires a NGF with a custom built, it only runs when
ginkgo runs with its label.

Testing:
Ran successfully:
- make test TAG=$(whoami) GINKGO_LABEL=telemetry PLUS_ENABLED=true
- make test TAG=$(whoami) GINKGO_LABEL=telemetry
- make test TAG=$(whoami) # here telemetry test was skipped, but all
  the rest ran successfully

ClOSES - nginx#1640
pleshakov added a commit to pleshakov/nginx-gateway-fabric that referenced this issue Mar 8, 2024
@pleshakov
Add functional test for product telemetry
7140244 
Problem:
Ensure product telemetry feature is tested with a functional test

Solution:
- Add a functional test.
- Because it requires a NGF with a custom built, it only runs when
ginkgo runs with its label.

Testing:
Ran successfully:
- make test TAG=$(whoami) GINKGO_LABEL=telemetry PLUS_ENABLED=true
- make test TAG=$(whoami) GINKGO_LABEL=telemetry
- make test TAG=$(whoami) # here telemetry test was skipped, but all
  the rest ran successfully

ClOSES - nginx#1640
pleshakov added a commit to pleshakov/nginx-gateway-fabric that referenced this issue Mar 8, 2024
@pleshakov
Add functional test for product telemetry
45aa02d 
Problem:
Ensure product telemetry feature is tested with a functional test

Solution:
- Add a functional test.
- Because it requires a NGF with a custom built, it only runs when
ginkgo runs with its label.

Testing:
Ran successfully:
- make test TAG=$(whoami) GINKGO_LABEL=telemetry PLUS_ENABLED=true
- make test TAG=$(whoami) GINKGO_LABEL=telemetry
- make test TAG=$(whoami) # here telemetry test was skipped, but all
  the rest ran successfully

ClOSES - nginx#1640
pleshakov added a commit to pleshakov/nginx-gateway-fabric that referenced this issue Mar 8, 2024
@pleshakov
Add functional test for product telemetry
04b783b 
Problem:
Ensure product telemetry feature is tested with a functional test

Solution:
- Add a functional test.
- Because it requires a NGF with a custom built, it only runs when
ginkgo runs with its label.

Testing:
Ran successfully:
- make test TAG=$(whoami) GINKGO_LABEL=telemetry PLUS_ENABLED=true
- make test TAG=$(whoami) GINKGO_LABEL=telemetry
- make test TAG=$(whoami) # here telemetry test was skipped, but all
  the rest ran successfully

ClOSES - nginx#1640
@pleshakov pleshakov mentioned this issue Mar 8, 2024
Merged
6 tasks
pleshakov added a commit to pleshakov/nginx-gateway-fabric that referenced this issue Mar 11, 2024
@pleshakov
Add functional test for product telemetry
fd959f3 
Problem:
Ensure product telemetry feature is tested with a functional test

Solution:
- Add a functional test.
- Because it requires a NGF with a custom built, it needs to run with
telemetry label.

Testing:
Ran successfully:
- make test TAG=$(whoami) GINKGO_LABEL=telemetry
- make test TAG=$(whoami) # telemetry test didn't run as expected,
  the functional test succeeded

ClOSES - nginx#1640
pleshakov added a commit to pleshakov/nginx-gateway-fabric that referenced this issue Mar 13, 2024
@pleshakov
Add functional test for product telemetry
e332008 
Problem:
Ensure product telemetry feature is tested with a functional test

Solution:
- Add a functional test.
- Because it requires a NGF with a custom built, it needs to run with
telemetry label.

Testing:
Ran successfully:
- make test TAG=$(whoami) GINKGO_LABEL=telemetry
- make test TAG=$(whoami) # telemetry test didn't run as expected,
  the functional test succeeded

ClOSES - nginx#1640
pleshakov added a commit that referenced this issue Mar 13, 2024
@pleshakov @sjberman
Add functional test for product telemetry (#1659)
f059cf0 
* Add functional test for product telemetry

Problem:
Ensure product telemetry feature is tested with a functional test

Solution:
- Add a functional test.
- Because it requires a NGF with a custom built, it needs to run with
telemetry label.
- Enable telemetry test in the pipeline

Testing:
Ran successfully:
- make test TAG=$(whoami) GINKGO_LABEL=telemetry
- make test TAG=$(whoami) # telemetry test didn't run as expected,
  the functional test succeeded
Also, the pipeline runs telemetry tests successfully

ClOSES - #1640

Co-authored-by: Saylor Berman <[email protected]>
amimimor pushed a commit to amimimor/nginx-gateway-fabric that referenced this issue Apr 3, 2024
@pleshakov @sjberman @amimimor
Add functional test for product telemetry (nginx#1659)
f5ecd14 
* Add functional test for product telemetry

Problem:
Ensure product telemetry feature is tested with a functional test

Solution:
- Add a functional test.
- Because it requires a NGF with a custom built, it needs to run with
telemetry label.
- Enable telemetry test in the pipeline

Testing:
Ran successfully:
- make test TAG=$(whoami) GINKGO_LABEL=telemetry
- make test TAG=$(whoami) # telemetry test didn't run as expected,
  the functional test succeeded
Also, the pipeline runs telemetry tests successfully

ClOSES - nginx#1640

Co-authored-by: Saylor Berman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pleshakov pleshakov

Labels
refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week tests Pull requests that update tests
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
2 participants
@pleshakov @mpstefan