feat: allow multiple -notify-sighup / -notify-container #622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-notify-sighup
and-notify-container
option were obviously planned to allow them to be passed multiple times, since they're internally stored as amap
of container ID (string
) to signal (int
). This PR make it possible to use both of those options multiple times, like this:This would send HUP (1) to container1 and container2 and INT (2) to container3 and container4.
For notifying large amount of containers, the recently added
-notify-filter
is preferable.There was also a TODO for preventing duplicate paths being passed to
-config
that this PR fixes.