Add UNKNOWN option to PolarizationType and DualPolarizationType #58

JonathanMeans · 2016-04-04T13:46:52Z

The FrameType was in enums.txt, but not in Enums.h. The FrameType used in the six code gets typedefed over from scene, so I just removed it from the .txt.

asylvest · 2016-04-04T18:45:46Z

@JonathanMeans I just looked through the code and schemas. Please double-check this but I believe that...

C++ PolarizationSequenceType == SICD schema Polarization1Type and should include UNKNOWN and SEQUENCE. RadarCollection.txPolarization uses this. So this one was right previously.

C++ PolarizationType == SICD schema Polarization2Type == SIDD schema sicommon:PolarizationType and does not include UNKNOWN and SEQUENCE. SICD's RadarCollection.txSequence.txStep.txPolarization and SIDD's TxRcvPolarization.txPolarization and .rcvPolarization use this. So this one was right previously too (and so the new enum value should be removed).

C++ DualPolarizationType == SICD schema DualPolarizationType and should include UNKNOWN but did not previously, so this addition was correct.

Can you verify and update the code accordingly? Also, since you have to update enums.txt with this and it looks like things were out of sync with it and Enums.h based on the other stuff you needed to add in... remove CornerIndex from enums.txt too as it is not needed and was not in Enums.h previously.

asylvest · 2016-04-04T18:46:24Z

six/modules/c++/six.sidd/source/Utilities.cpp

@@ -418,6 +418,8 @@ six::PolarizationType _convertDualPolarization(six::DualPolarizationType pol,
                        : six::PolarizationType::RHC;
    case six::DualPolarizationType::LHC_LHC:
        return six::PolarizationType::LHC;
+    case six::DualPolarizationType::UNKNOWN:


I think line endings are goofed up on these two lines (don't just do a dos2unix under this pull request as lots of lines in this file unfortunately are wrong)

JonathanMeans · 2016-04-04T19:02:04Z

Ah, was looking at the 1.1 spec.

Since DualPolarization has UNKNOWN and Polarization doesn’t, in sidd/Utilites.cpp _convertDualPolarization, would DualPolarizationType::UNKNOWN map to PolarizationType::OTHER?

From: Adam Sylvester [mailto:[email protected]]
Sent: Monday, April 04, 2016 2:46 PM
To: ngageoint/six-library [email protected]
Cc: Jonathan Means [email protected]
Subject: Re: [ngageoint/six-library] Add UNKNOWN option to PolariztionType and DualPolarizationType (#58)

@JonathanMeanshttp://cp.mcafee.com/d/1jWVIe6wUgdEIfCzAsqenTS7ztPrb38UsqenTPrUVBxB4QsCzASztWXPxEVKqenzqabaarVEVsovdydorcDIel_ok1iG6JQVsSGxHtendSvs89T7fZvxPdXIetuVtdcsNObWq8VYQsZh5dqWqJPhONOEuvkzaT0QSyrjdTV5MQsL8EIFTudTdAVPmEBC4pj9JAenM2aMSpfo3vX2xK5o-Ium1h6kOrp3BPrXP39I5-Aq83iT0zF7WOxfai3OVYy4tymdbFEw4443h04Mo1gc302wMQglmDaI3h1eFEw2RjZz8kDaI0immYQgr10Qg1PuDxqF-NAarelo0AIJVEwd506fL6yASqen3tO76OB2P I just looked through the code and schemas. Please double-check this but I believe that...

C++ PolarizationSequenceType == SICD schema Polarization1Type and should include UNKNOWN and SEQUENCE. RadarCollection.txPolarization uses this. So this one was right previously.

C++ PolarizationType == SICD schema Polarization2Type == SIDD schema sicommon:PolarizationType and does not include UNKNOWN and SEQUENCE. SICD's RadarCollection.txSequence.txStep.txPolarization and SIDD's TxRcvPolarization.txPolarization and .rcvPolarization use this. So this one was right previously too (and so the new enum value should be removed).

C++ DualPolarizationType == SICD schema DualPolarizationType and should include UNKNOWN but did not previously, so this addition was correct.

Can you verify and update the code accordingly? Also, since you have to update enums.txt with this and it looks like things were out of sync with it and Enums.h based on the other stuff you needed to add in... remove CornerIndex from enums.txt too as it is not needed and was not in Enums.h previously.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttp://cp.mcafee.com/d/k-Kr4wUSyM-qehNEVvvoudTdIIczxNEVvvdLzCm6kjhOqejqdTHLe6zCVEVudEEIEFLCzBNxYS8RxIOuMVnZxg5aEqTjBPqG6JQVsTpZMwDss_R-7cTKMVRXBQQNP78LFEzDPhPR4kRHFGTd7b7axVZicHs3jqpJcTvAn3hOYyyODtUTsSjDdqymohBcCSgVv84t8_mk9VigunfAgzIiSbdDDU-Y1AGkrZtnUjbFTvooppjodMH7RzOMa8OCjr8sKrvuopdwLQzh0qmU4t8_mk9VigunfAgzIiNFtd40wwwq80C30a1wo0k66y2GQVlwq89Rd40mGvIp2AVlw2iOTCy3o86y0erQYblfScxjpOH04BBLd41EE0NZUQkCPhOUrezwgJJkhXG7W

The information contained in this communication is confidential, is intended only for the use of the recipient(s) named above, and may be legally privileged. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this communication is strictly prohibited. If you have received this communication in error, please re-send this communication to the sender and delete the original message or any copy of it from your computer system.

asylvest · 2016-04-04T19:08:27Z

Hmm, good question. To be safe, let's have it throw in that case... if we ever run into it, we can re-evaluate.

JonathanMeans · 2016-04-04T19:34:56Z

Changes are made.

(I pulled up Utilities.cpp in Notepad++. It showed consistent CRLF line-endings in the area around the comment. Not sure what else I should be doing about that.)