Add PVPBlock constructor that populates its members from raw data #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * parameter in a PVP set. | ||
| * \param data Actual PVP data, used to set the PVPSet members | ||
| */ | ||
|
|
JonathanMeans
added a commit
that referenced
this pull request
Feb 20, 2020
fff9e63 Merge pull request #310 from mdaus/better_bytes_handling 7c9b4d8 Fix module name again 8e7efc8 Fix module name in copyright d150099 Fix writing to StringStream from Python 6de9e9d Merge pull request #309 from mdaus/mt-autoptr-fix 5f52ebf Merge branch 'master' into mt-autoptr-fix b58d1f4 Restored old functionality using an initial offset to CPUAffinityInitializerLinux 553a93f Merge pull request #308 from mdaus/python_bindings b4ed564 Updated AbstractedTiedThreadPool and TiedWorkerThread to accept std::auto_ptr<CPUAffinityThreadInitializer>. Additionally, fixed a lot of tab vs space and formatting bb0e93e Regenerate Python bindings 7e437f7 Merge pull request #307 from mdaus/affinity-thread-pinning ecc9515 Review changes 2f9b657 Cleaned up mt wscript 64e7cf0 Fixed docs f7890dd CPUAffinityInitializers now return auto_ptrs. Note that this requires some goofiness to have a covariant auto_ptr 3f51873 Fixed Windows problems 2a26f52 Added documentation 21d4921 Use MT_FORCE_PINNING define to change the default value of pinToCore 780da57 Moved static method getNumOnlineCPUs() to ScopedCPUMaskUnix... is this less goofy? Hard to say. At least now ScopedCPU*Unix classes are decoupled except through inheritance 58c217d ScopedCPUAffinityUnix now inherits from ScopedCPUMaskUnix. Eliminates all the goofy delegation. 59975fa Documentation 49ae7dc Documentation 27a5703 Added configure-time flag to force thread pinning in ThreadGroup 4d21073 Added ThreadGroupAffinityTest to demonstrate the effects of pinning using a simulated workload 904a194 Pulled ScopedCPUAffinityUnix and ScopedCPUMaskUnix out into their own file 3ef1b97 Pulled ScopedCPUAffinityUnix and ScopedCPUMaskUnix out into their own file bca962a Updated ThreadGroup to use CPUAffinityInitializer to pin threads to CPUs if requested 0327b4e OS switching functionality in 5c042b7 Getting multi-os framework in place... 023ace4 Moved CPUAffinity*Initializer to AbstractCPUAffinity*Initializer -- moving toward the operating system switching paradigm used in sys c09cb4a Updated comments eaa4169 Added OS::getAvailableCPUs function that returns two lists: 1) a list of affinity-masked physical CPUs and 2) a list of affinity-masked hyperthreaded CPUs 8ed5880 Merge pull request #306 from mdaus/physical-core-subset 5c551c3 Changed name from CPUMask to ScopedCPUMask bb8c5d4 Pulled the CPU mask out into its own RAII class a5a8b90 Updates to CPU count functionality if the number of CPUs available exceeds the capacity of the default size of cpu_set_t e790228 Merge pull request #305 from mdaus/physical-core-subset 9c6ad8c Bring CPUTest in-line with newer applications 56d6be4 Little refactoring c5143ba Added affinity-aware versions of getNumCPUs() and getNumPhysicalCPUs() 6d089b5 Merge pull request #304 from mdaus/core-counting 557f806 Review changes 32612b2 Throw NotYetImplemented exception in OSWin32::getNumPhysicalCPUs() 624c96a Added physical CPU check for Unix by parsing /sys/devices/system/cpu/cpu*/topology/thread_siblings_list git-subtree-dir: externals/coda-oss git-subtree-split: fff9e63e763896ec6eba6e63d4ef5ce02fa1714d
JonathanMeans
added a commit
that referenced
this pull request
Feb 24, 2020
dbabd95 Merge pull request #315 from mdaus/update_waf 4a5cb5c Fix waf to work with Python 3.7 8b862c9 Merge pull request #314 from mdaus/rebuild_python 8e8e9ff Regenerate python bindings dea423f Merge pull request #313 from creffett/mt_cpu_affinity c2b0fc8 ThreadGroupTest: minor style fixes d8eb1da ThreadGroup: Remove extraneous const-qualifier f0d1cfc ThreadGroup: remove extraneous newline 08a3ce0 ThreadGroup: document CPU pinning getter/setter 9ae0cd5 ThreadGroup: change static var name to underscore + caps style d0f6a39 Tweak the description for default-cpu-pinning 13d7272 Add PinToCPUTest to ThreadGroupTest 69e3ac2 Add method to ThreadGroup to check whether CPU affinity is enabled 67e7ba9 Add support for changing thread affinity at runtime f4e94ea Merge pull request #311 from mdaus/polygon-intersections 792a1da Cleanup 0a5e35f Needless line ba67ee7 Enhancements to polygon::Intersections to handle cases when the polygon partially clips an image fff9e63 Merge pull request #310 from mdaus/better_bytes_handling 7c9b4d8 Fix module name again 8e7efc8 Fix module name in copyright d150099 Fix writing to StringStream from Python 6de9e9d Merge pull request #309 from mdaus/mt-autoptr-fix 5f52ebf Merge branch 'master' into mt-autoptr-fix b58d1f4 Restored old functionality using an initial offset to CPUAffinityInitializerLinux 553a93f Merge pull request #308 from mdaus/python_bindings b4ed564 Updated AbstractedTiedThreadPool and TiedWorkerThread to accept std::auto_ptr<CPUAffinityThreadInitializer>. Additionally, fixed a lot of tab vs space and formatting bb0e93e Regenerate Python bindings 7e437f7 Merge pull request #307 from mdaus/affinity-thread-pinning ecc9515 Review changes 2f9b657 Cleaned up mt wscript 64e7cf0 Fixed docs f7890dd CPUAffinityInitializers now return auto_ptrs. Note that this requires some goofiness to have a covariant auto_ptr 3f51873 Fixed Windows problems 2a26f52 Added documentation 21d4921 Use MT_FORCE_PINNING define to change the default value of pinToCore 780da57 Moved static method getNumOnlineCPUs() to ScopedCPUMaskUnix... is this less goofy? Hard to say. At least now ScopedCPU*Unix classes are decoupled except through inheritance 58c217d ScopedCPUAffinityUnix now inherits from ScopedCPUMaskUnix. Eliminates all the goofy delegation. 59975fa Documentation 49ae7dc Documentation 27a5703 Added configure-time flag to force thread pinning in ThreadGroup 4d21073 Added ThreadGroupAffinityTest to demonstrate the effects of pinning using a simulated workload 904a194 Pulled ScopedCPUAffinityUnix and ScopedCPUMaskUnix out into their own file 3ef1b97 Pulled ScopedCPUAffinityUnix and ScopedCPUMaskUnix out into their own file bca962a Updated ThreadGroup to use CPUAffinityInitializer to pin threads to CPUs if requested 0327b4e OS switching functionality in 5c042b7 Getting multi-os framework in place... 023ace4 Moved CPUAffinity*Initializer to AbstractCPUAffinity*Initializer -- moving toward the operating system switching paradigm used in sys c09cb4a Updated comments eaa4169 Added OS::getAvailableCPUs function that returns two lists: 1) a list of affinity-masked physical CPUs and 2) a list of affinity-masked hyperthreaded CPUs 8ed5880 Merge pull request #306 from mdaus/physical-core-subset 5c551c3 Changed name from CPUMask to ScopedCPUMask bb8c5d4 Pulled the CPU mask out into its own RAII class a5a8b90 Updates to CPU count functionality if the number of CPUs available exceeds the capacity of the default size of cpu_set_t e790228 Merge pull request #305 from mdaus/physical-core-subset 9c6ad8c Bring CPUTest in-line with newer applications 56d6be4 Little refactoring c5143ba Added affinity-aware versions of getNumCPUs() and getNumPhysicalCPUs() 6d089b5 Merge pull request #304 from mdaus/core-counting 557f806 Review changes 32612b2 Throw NotYetImplemented exception in OSWin32::getNumPhysicalCPUs() 624c96a Added physical CPU check for Unix by parsing /sys/devices/system/cpu/cpu*/topology/thread_siblings_list git-subtree-dir: externals/coda-oss git-subtree-split: dbabd95d15f40ff20ac6b71e0c292d0b5dac3de8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @vkrishna1997