Fix unsigned difference #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhamc
pushed a commit
to stringhamc/six-library
that referenced
this pull request
Mar 22, 2019
026c665 Merge pull request ngageoint#255 from mdaus/updateWscripts b88a2ce Update wscripts to work properly 059e0fc Merge pull request ngageoint#254 from mdaus/ignoreJ2k 374e701 Add new driver to gitignore bca6b3c Merge pull request ngageoint#253 from mdaus/addJ2k 7fb4541 Add J2K driver from NITRO 9063b5f Merge pull request ngageoint#252 from mdaus/ceilingDivide 29ebc51 Remove unneeded headers 928998b Remove commented code 629deda Move ceilingDivide to .cpp; apply elsewhere 4a953b8 Add ceilingDivide function; update Python git-subtree-dir: externals/coda-oss git-subtree-split: 026c6652d9866f5d29cae085df9f1f6864774ca3
JonathanMeans
added a commit
that referenced
this pull request
Feb 24, 2020
026c665 Merge pull request #255 from mdaus/updateWscripts b88a2ce Update wscripts to work properly 059e0fc Merge pull request #254 from mdaus/ignoreJ2k 374e701 Add new driver to gitignore bca6b3c Merge pull request #253 from mdaus/addJ2k 7fb4541 Add J2K driver from NITRO git-subtree-dir: externals/coda-oss git-subtree-split: 026c6652d9866f5d29cae085df9f1f6864774ca3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core issue was trying to take the difference of two unsigned types. The compiler complained because
absis not overloaded for unsigned types.