initialize gain and phase polys in ctor #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanMeans
added a commit
that referenced
this pull request
Jun 12, 2019
c2489fe Merge pull request #208 from mdaus/polyChecks 5b6a037 Add check for Poly1D.fromArray 3e68b18 Add some safety checks when converting Polys to and from numpy arrays 41065e2 Merge pull request #206 from mdaus/remove_curl_env_pollution 2eeca61 Merge pull request #207 from mdaus/fix_include_guard 3a23d69 Fixing include guard 0682acc Need to undefine HAVE_CURL_GLOBAL_INIT or else it ends up in the waf environment 81002ad Merge pull request #205 from mdaus/cliErrorMessage 576f028 More verbose error message for invalid cli key d551442 Merge pull request #204 from mdaus/libcurl-link d54f4de Some systems require explicitly adding curl to link line 30de0ce Merge pull request #202 from mdaus/buildRefactor 499ef22 Merge pull request #203 from mdaus/install-tgt-fix 7954e52 Updated install_tgt after testing with --install-source dadd7a1 Changed input to be self instead of tsk c66b774 install_tgt does not have self as an input parameter f5d98e2 Merge pull request #201 from mdaus/pyInitFix 1a18f65 Extract another function; resolve targets_to_add/targetsToAdd naming inconsistency bdbac8f Explain the fix 5fd1058 More built-in way of guarding against double-installation 4408d50 Include whitespace change 7050277 Merge branch 'master' into pyInitFix 3a8b8b8 Only create one __init__.py per project, to prevent race conditions 2f2c23f Merge pull request #200 from mdaus/revertInit 3485d90 Revert __init__.py change bcd3b41 Merge pull request #198 from mdaus/pyInitFix d1b2a32 Merge pull request #199 from mdaus/buildRefactor 7448249 Pass an argument instead of modifying modArgs d42db38 Properly modify modArgs 7ccc3b4 Extract some repeated code into functions 99d3be0 Remove check that __init__ isn't install 884ad04 Merge pull request #197 from mdaus/pythonTestTarget 688ecf5 Python tests only install when asked, and when everything is installed 9084676 Fix bug in creating __init__.py 8e1b43b Clean up be131fb Prevent installation of python tests if not requested 9d24cdd Merge pull request #196 from mdaus/fixImports f92b113 Fix imports 70b8180 Merge pull request #194 from mdaus/mathUtils 911e578 Review fixes d8444d9 Merge pull request #195 from mdaus/add-curl-handle fcbfb72 Added a newline to the end of file 2746903 Moved includes to be inside the #ifdef check 6f81af1 Added check for CURL 63d6634 Added curl handle ff9dd87 Review fixes 3c67452 Add trailing newline c2b09e8 Add nChooseK function f2d4539 Merge pull request #193 from mdaus/matlabConfigFix e290bdb Continue config if can't find mexext 3f2a7ca Merge pull request #192 from mdaus/fix_gcc62 bd8c12b Finalize fixes 053b7be Add untested attempt at expanding symlinks 86b0742 Not sure why this used to be linux/unistd.h - we should be able to use unistd.h directly. gcc 6.2 and/or Alpine Linux can't find linux/unistd.h so switching this. 98f5f0f gcc 6.2 warns that this should have a cast - according to the man page, this is true git-subtree-dir: externals/coda-oss git-subtree-split: c2489fe74942f5a134f814a7335eec0375af5319
JonathanMeans
pushed a commit
that referenced
this pull request
Feb 24, 2020
2645b4f Merge pull request #211 from mdaus/logging-improvements 268e38b Added mClosed to init list 3070346 Updated handlers to avoid calling virtual methods in the destructor 6fe1538 Merge pull request #210 from mdaus/vectorString ca69675 Move VectorString to coda_types 55e9b33 Merge pull request #209 from mdaus/nanCheck 01df546 Add copyright 0ce5221 Make some test macros work against NaNs c2489fe Merge pull request #208 from mdaus/polyChecks 5b6a037 Add check for Poly1D.fromArray 3e68b18 Add some safety checks when converting Polys to and from numpy arrays 41065e2 Merge pull request #206 from mdaus/remove_curl_env_pollution 2eeca61 Merge pull request #207 from mdaus/fix_include_guard 3a23d69 Fixing include guard 0682acc Need to undefine HAVE_CURL_GLOBAL_INIT or else it ends up in the waf environment 81002ad Merge pull request #205 from mdaus/cliErrorMessage 576f028 More verbose error message for invalid cli key d551442 Merge pull request #204 from mdaus/libcurl-link d54f4de Some systems require explicitly adding curl to link line 30de0ce Merge pull request #202 from mdaus/buildRefactor 499ef22 Merge pull request #203 from mdaus/install-tgt-fix 7954e52 Updated install_tgt after testing with --install-source dadd7a1 Changed input to be self instead of tsk c66b774 install_tgt does not have self as an input parameter f5d98e2 Merge pull request #201 from mdaus/pyInitFix 1a18f65 Extract another function; resolve targets_to_add/targetsToAdd naming inconsistency bdbac8f Explain the fix 5fd1058 More built-in way of guarding against double-installation 4408d50 Include whitespace change 7050277 Merge branch 'master' into pyInitFix 3a8b8b8 Only create one __init__.py per project, to prevent race conditions 2f2c23f Merge pull request #200 from mdaus/revertInit 3485d90 Revert __init__.py change bcd3b41 Merge pull request #198 from mdaus/pyInitFix d1b2a32 Merge pull request #199 from mdaus/buildRefactor 7448249 Pass an argument instead of modifying modArgs d42db38 Properly modify modArgs 7ccc3b4 Extract some repeated code into functions 99d3be0 Remove check that __init__ isn't install 884ad04 Merge pull request #197 from mdaus/pythonTestTarget 688ecf5 Python tests only install when asked, and when everything is installed 9084676 Fix bug in creating __init__.py 8e1b43b Clean up be131fb Prevent installation of python tests if not requested 9d24cdd Merge pull request #196 from mdaus/fixImports f92b113 Fix imports 70b8180 Merge pull request #194 from mdaus/mathUtils 911e578 Review fixes d8444d9 Merge pull request #195 from mdaus/add-curl-handle fcbfb72 Added a newline to the end of file 2746903 Moved includes to be inside the #ifdef check 6f81af1 Added check for CURL 63d6634 Added curl handle ff9dd87 Review fixes 3c67452 Add trailing newline c2b09e8 Add nChooseK function f2d4539 Merge pull request #193 from mdaus/matlabConfigFix e290bdb Continue config if can't find mexext 3f2a7ca Merge pull request #192 from mdaus/fix_gcc62 bd8c12b Finalize fixes 053b7be Add untested attempt at expanding symlinks 86b0742 Not sure why this used to be linux/unistd.h - we should be able to use unistd.h directly. gcc 6.2 and/or Alpine Linux can't find linux/unistd.h so switching this. 98f5f0f gcc 6.2 warns that this should have a cast - according to the man page, this is true 7c39239 Merge pull request #191 from mdaus/swig-python-extra-native-containers ec4d5f1 defaulting SWIG_PYTHON_EXTRA_NATIVE_CONTAINERS 6dcac97 Merge pull request #190 from mdaus/thread_planner b26de0e Member initialization should be on separate lines d71d3ed Hadn't clicked save before pushing - some more Doxygen comments 860adee Adding a new method to get the number of threads that will actually be used. Adding Doxygen. 85a2433 Merge pull request #189 from mdaus/cleanup b6ec743 Remove unused variables dba6ab3 Merge pull request #187 from mdaus/tempfile 64648fa Prevent memory leak on error; make tempfile uncopyable, unassignable 2e8229f Remove warning; use vector<char> instead of array 8555040 Remove unneeded include 8b17367 Remove option to not destroy tempfile; document getTempFile() side-effect b264832 Move TempFile to io; simply things a0107a0 Add TempFile class git-subtree-dir: externals/coda-oss git-subtree-split: 2645b4f9b008fc219d41f1b1b5c0170bf9aae949
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.