-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in start row > 4GB into an image segment #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c73ffd6 Merge pull request #35 from mdaus/fix_uint64_offset_bug 83ab818 Added const to fix a compiler warning bdf0dc1 Fixed subtle bug in handling of 64-bit offsets... previously, if we tried to read in with an initila offset > 4 GB into an image segment, this did not work properly because it was treated as a 32-bit number in one of the calculations. Also added a few compiler warnings. 60c8b67 Merge commit '77fbcc1f15a1f039e8d9b5b668d0e93816524c0b' 77fbcc1 Squashed 'externals/coda-oss/' changes from ba5cb1d..2645b4f git-subtree-dir: externals/nitro git-subtree-split: c73ffd6
JonathanMeans
pushed a commit
that referenced
this pull request
Jun 12, 2019
80cee56 Merge pull request #172 from mdaus/wheel 530989d Specify bin dir in wheel command 76a38a1 Fix spacing issues 61577f3 Remove extraeneous line 6bec950 Move wheel to bin during creation 15e9e4a Set env variable for location of setup.py 11b82ed Fix spacing 084f591 Install setup.py to cwd, remove unused assignments, put wheel straight into bin 5ea9dce Add trailing newline 2f4acf6 Revert accidental change 7f96e7a Don't have to worry about cleaning up extra wheels, since they aren't getting built 2b21629 Don't build dependencies with wheel 481e4de Add package and makewheel commands for distribution 63990c0 Merge pull request #171 from mdaus/fix_pcre_windows 462612b Needing to add PCRE2_STATIC in one more spot for Windows to link properly fb1bd91 Removing stray printout 8ba069f Merge pull request #138 from mdaus/stdregex 661fa7f Merge pull request #160 from mdaus/pcre2 6158d9f Removed a todo and added a flag in the comment 9f31903 Minor fix to get --install-source working 308a96c Need to add in sys/Conf.h since a sys header isn't getting included in Regex.h now 426339a Added new --enable-std-regex flag and using this to key off of whether PCRE or the STL should be used 5869686 update RegexSTL to handle overlapping regexes; add more edge cases to unit tests 8d554c9 Merge branch 'pcre2' of https://github.com/mdaus/coda-oss into pcre2 3fa9d4d Fixed a number of edge conditions in the PCRE implementation and added more unittest coverage. c0dbdab Merge branch 'stdregex' into pcre2 430a69c Updating .gitignore with new PCRE subdirectory 9896d1e Added cpp file for common function across PCRE and STL implementations a60b9bc Style cleanup and removing any duplicate code between the PCRE and STL implementations. escape() can be static. Tried to add more details in comments about what the methods provide. ebfbe74 Updating wscript to reflect target names all with PCRE in them now rather than PCRE2 736efe6 Removing old pcre2 directory f38f6eb Starting process of moving modules/drivers/pcre2 into modules/drivers/pcre 3ba1287 Removing old PCRE implementation. Moving new PCRE2 implementation in place. 5a455f8 Got installation of headers and libraries in place. Added distclean in. e5dd293 Finishing PCRE2 configure checks and now actually successfully building the library c0318de Adding part of the logic to build PCRE2 from source tarball... a good chunk of the way through generating the config.h file that we need 8a7af1d Added the ability for untarFile() to send in a mode string so you can use it with .tar.gz files 29434ee Adding PCRE2 tarball ea10140 Adding a TODO cd3a99a Replaced tabs with spaces! ed69970 Improved checking / added a few more unit tests a034553 Corrected a bunch of indexing with how begin/end differs from before due to us not doing substr() anymore... unit tests all pass now 5dab6f9 allow passing regexp from command line; remove C++11 code 5a958a8 Merge branch 'stdregex' into pcre2 fa5c8e8 Adding more PCRE2 functionality. Something with the indexing is wrong in searchAll() right now... test_regex does NOT pass 72db0fb Starting to put pcre2_match() into PCRE2 implementation d8d0543 add a benchmark for re::Regex 58f5bcf Adding partial support for PCRE2 f3177b6 move as much processing as possible to Regex::compile(); start using the std::regex::optimize flag (which doesn't seem to do much) 9ded27b add TEST_THROWS to test whether code throws something (anything) c9a7823 do our own exception test since TEST_EXCEPTION can't handle STL exceptions 975e42e rename mOvectorCount -> OVECTOR_COUNT abf85c4 style cleanups; pass exception on to user 29705c2 make OVECCOUNT static; clean up error messages 17e8cd1 make OVECCOUNT static; clean up comments and descriptions 587cf93 remove commented-out code; add "return 0" 121db90 style corrections df6556d need to clear match vector before use for old PCRE interface; don't include exception testing when CPP11 is disabled 5376a40 move search() with flag parameter to private internal f68e638 need internal function for passing flags to pcre_exec() 29a62dd remove Regex compile flags parameter 25404b0 remove Regex compile flags parameter f8aace8 remove Regex search flags parameter c952d30 copy RegexTest3.cpp into unit tests 76cbc8d expand unit tests 7efae41 convert searchAll() to use searchWithContext() 49540d5 add more unit tests 6609bd4 add tests for ^ or $ in the middle of the string d2d08c8 add workaround for issue with VS2015 treating "^foo" differently than gcc 39da2e1 fix regex mistake in replaceDot() f096974 tidy up a few mistakes 20b2ae4 OVECCOUNT should only exist #ifndef __CODA_CPP11 f36e2e1 protected -> private 21cfb2b rename PCRE -> Regex everywhere bace6dd rename PCRE -> Regex everywhere 38fb81d rename files 05faa44 style fixes 7d19a8b style fixes; convert mOvector to an actual vector 93b0e51 style fixes; remove unused USE_PCRE define; convert mOvector to an actual vector 031db11 fix type for Content-Type ca06e28 add ability to work with PCRE_DOTALL newline matching 5b43705 add "break" to kill infinite loop on error 5c42c95 add unit test for PCRE_DOTALL flag behavior adc62ea add second source file for C++11 std::regex, protected by preprocessor define __CODA_CPP11 git-subtree-dir: externals/coda-oss git-subtree-split: 80cee566df8cf98416cef9290f38bfa61fbbe689
JonathanMeans
pushed a commit
that referenced
this pull request
Feb 24, 2020
ba5cb1d Merge pull request #185 from mdaus/numpyTypes 64e84d3 Fix merge conflict e431254 Add consts 9d5bf82 Merge pull request #188 from mdaus/mathMisc 681e019 Add math utilities to support SICD validation bc69e0b Fix space cd7c72f Add comments 8fecda5 Move function implementation to hpp file fbee286 Add conversion of Poly2D d6fc5d2 Check in working progress c5111f4 Merge pull request #183 from mdaus/wheelTargets deaeeca Merge pull request #184 from mdaus/adding-banners 9a1a321 Added banners 8202b18 Allow to specify targets for makewheel 373e275 Merge pull request #181 from mdaus/matrixTemplates 991b63d Get rid of useless parameter 0520adf Generalize with SWIG macros dedaba6 Fix pickle import 24c9c12 Merge branch 'master' into matrixTemplates 72667a9 Add matrices of dimensions (and transposes) used in SIX to Python layer 6d2450d Merge pull request #179 from mdaus/fix_pcre_compilation c2f7555 Variable name had gotten out of sync 3fded3d Test conversion functions c6c565c Merge pull request #177 from mdaus/fix-drivers-configuration 01d020f Merge pull request #175 from mdaus/regex-url-fix e1540b3 Updated the recurse directories so drivers would always be first d8a28d7 Added a comment explaining the change, and changed the variable name to match what is happening 41617c1 Updates based on review comments d46b389 Merge pull request #176 from mdaus/fix_boost_check 1d9eaa3 Need to make HAVE_BOOST check smarter in case modules/drivers/boost doesn't exist at all 96c1724 Removed extra call to testMatchOptional 2d8dbc1 Updated regex to not throw when a url is parsed db76994 Merge pull request #174 from mdaus/pickleType afb0612 Import proper pickle in coda_types 80cee56 Merge pull request #172 from mdaus/wheel 530989d Specify bin dir in wheel command 76a38a1 Fix spacing issues 61577f3 Remove extraeneous line 6bec950 Move wheel to bin during creation 15e9e4a Set env variable for location of setup.py 11b82ed Fix spacing 084f591 Install setup.py to cwd, remove unused assignments, put wheel straight into bin 5ea9dce Add trailing newline 2f4acf6 Revert accidental change 7f96e7a Don't have to worry about cleaning up extra wheels, since they aren't getting built 2b21629 Don't build dependencies with wheel 481e4de Add package and makewheel commands for distribution 63990c0 Merge pull request #171 from mdaus/fix_pcre_windows 462612b Needing to add PCRE2_STATIC in one more spot for Windows to link properly fb1bd91 Removing stray printout 8ba069f Merge pull request #138 from mdaus/stdregex 6af3363 Merge pull request #170 from mdaus/swigVersionCheck fcfe4b6 Fix checking for SWIG version aa0f352 Merge pull request #169 from mdaus/cPickleFix b1d4548 Regenerated with SWIG 3.0.10 36c9ac5 Fix how pickle gets imported for Python3 a57581a Because of how it's processed, msvs.py actually needs tabs instead of spaces 2891a55 Merge pull request #166 from mdaus/python3Fixes 49aaf97 Update lingering issues that only worked in Python2 661fa7f Merge pull request #160 from mdaus/pcre2 6158d9f Removed a todo and added a flag in the comment 9f31903 Minor fix to get --install-source working 308a96c Need to add in sys/Conf.h since a sys header isn't getting included in Regex.h now 426339a Added new --enable-std-regex flag and using this to key off of whether PCRE or the STL should be used 5869686 update RegexSTL to handle overlapping regexes; add more edge cases to unit tests 8d554c9 Merge branch 'pcre2' of https://github.com/mdaus/coda-oss into pcre2 3fa9d4d Fixed a number of edge conditions in the PCRE implementation and added more unittest coverage. db4a977 Merge pull request #163 from mdaus/add_types_dep 137558e types-python should come in for math.poly too fa348c2 Merge pull request #162 from mdaus/add_generated_code b8589d5 Missed committing generated code previously ed6a6c3 Merge pull request #161 from mdaus/add_new_pickle_utils 7db9fc3 Added new pickling macros in types.i; applied to select math objects c0dbdab Merge branch 'stdregex' into pcre2 430a69c Updating .gitignore with new PCRE subdirectory 9896d1e Added cpp file for common function across PCRE and STL implementations a60b9bc Style cleanup and removing any duplicate code between the PCRE and STL implementations. escape() can be static. Tried to add more details in comments about what the methods provide. ebfbe74 Updating wscript to reflect target names all with PCRE in them now rather than PCRE2 736efe6 Removing old pcre2 directory f38f6eb Starting process of moving modules/drivers/pcre2 into modules/drivers/pcre 3ba1287 Removing old PCRE implementation. Moving new PCRE2 implementation in place. 5a455f8 Got installation of headers and libraries in place. Added distclean in. e5dd293 Finishing PCRE2 configure checks and now actually successfully building the library c0318de Adding part of the logic to build PCRE2 from source tarball... a good chunk of the way through generating the config.h file that we need 8a7af1d Added the ability for untarFile() to send in a mode string so you can use it with .tar.gz files 29434ee Adding PCRE2 tarball a459188 Merge pull request #159 from mdaus/sign 27b82da Fix signature b008cb4 Merge pull request #158 from mdaus/besselFunction ea10140 Adding a TODO cd3a99a Replaced tabs with spaces! ed69970 Improved checking / added a few more unit tests a034553 Corrected a bunch of indexing with how begin/end differs from before due to us not doing substr() anymore... unit tests all pass now 5dab6f9 allow passing regexp from command line; remove C++11 code f261a6f Remove unnecessary include 5b4763c Fix docstring d31d105 Add main arguments 4608a80 Add Sign function 2b71312 Use std::abs instead of std::fabs; fix naming 5a958a8 Merge branch 'stdregex' into pcre2 fa5c8e8 Adding more PCRE2 functionality. Something with the indexing is wrong in searchAll() right now... test_regex does NOT pass 72db0fb Starting to put pcre2_match() into PCRE2 implementation d8d0543 add a benchmark for re::Regex 02cc601 Add trailing newline 81cd168 Add Bessel function of the first kind 58f5bcf Adding partial support for PCRE2 aaa3270 Merge pull request #156 from mdaus/throw-invalid-fit c6a1974 remove comments a39d0a4 add a couple #includes 6888f52 Merge pull request #155 from mdaus/fixFindExecSolaris e149ff4 Merge pull request #154 from mdaus/matrix-negation-operator f3177b6 move as much processing as possible to Regex::compile(); start using the std::regex::optimize flag (which doesn't seem to do much) 2a4404d Merge pull request #157 from mdaus/dualCompatability 456b570 Fix Python3 compatability issue with cPickle eaba631 fit() throws if not enough points to constrain fit to unique solution; add unit tests for this 78d55de move Vector unit tests to test_Vector*.cpp; style cleanup 7c9b7b1 Check path before calling readLink 46a349f getCurrentExecutable() works by trying a number of different things on Unix machines, so it doesn't work to throw if readLink fails e7ef2fe modify unit tests so they will fail if negation operator does nothing; add #include<functional> to Matrix2D for std::negate 4200e30 add negation operators to math.linear objects 6ce19a0 Merge pull request #153 from mdaus/missed_swig_generation 680d231 Missed some Swig-generated files 8cadaed Merge pull request #146 from mdaus/currentPath 2751dbe Merge pull request #151 from mdaus/coda-oss-aar-polyeval 5052ceb Merge back from coda/aar-remove-polyeval ac54cbd Merge pull request #150 from mdaus/glibc_backtrace 0f5e4c4 Fixed string literal 3cc3088 Remove unused function d5dcf35 Merge pull request #147 from mdaus/glibc_backtrace dac4273 Merge pull request #148 from mdaus/installPython bb6f2b6 Fix typo a4bf515 Remove extra newlines 89b4a79 Remove whitespace changes eb8466b Install Python tests into test dir 11ddb8a Added RAII wrapper in Backtrace 330d35d Made backtrace const static, fixed typo 5f2944f Added short doxygen to backtrace d351c6a Added utility function to show a backtrace on glibc systems 33ce58c Update docstrings; make readlink wrapper more user-friendly 07e0308 Fix return type of helper function 3966d87 Add error-handling wrappers for a couple system calls 4c424c4 Add comment 6c36c42 Write getCurrentExecutable() for Unix 10f0f8b Handle XP edge case more safely 3ea2193 Add function to find current executable in the Windows and general cases 17be40c Merge pull request #145 from mdaus/add-pickling-coda_types 427016f Unittests for pickling coda_types 08216e8 Templated versions of pickle utilities 0163d0d Extended python coda_types to support pickling. d1177f0 Merge pull request #142 from mdaus/xml_lite_warnings 8f49445 Cleaning up a few warnings about unused variables 11482e4 Some of the TEST_DEPS weren't needed as they were already in MODULE_DEPS 9ded27b add TEST_THROWS to test whether code throws something (anything) c9a7823 do our own exception test since TEST_EXCEPTION can't handle STL exceptions 975e42e rename mOvectorCount -> OVECTOR_COUNT abf85c4 style cleanups; pass exception on to user 29705c2 make OVECCOUNT static; clean up error messages 17e8cd1 make OVECCOUNT static; clean up comments and descriptions 587cf93 remove commented-out code; add "return 0" 121db90 style corrections df6556d need to clear match vector before use for old PCRE interface; don't include exception testing when CPP11 is disabled 5376a40 move search() with flag parameter to private internal f68e638 need internal function for passing flags to pcre_exec() 29a62dd remove Regex compile flags parameter 25404b0 remove Regex compile flags parameter f8aace8 remove Regex search flags parameter c952d30 copy RegexTest3.cpp into unit tests 76cbc8d expand unit tests 7efae41 convert searchAll() to use searchWithContext() 49540d5 add more unit tests 6609bd4 add tests for ^ or $ in the middle of the string d2d08c8 add workaround for issue with VS2015 treating "^foo" differently than gcc 39da2e1 fix regex mistake in replaceDot() f096974 tidy up a few mistakes 20b2ae4 OVECCOUNT should only exist #ifndef __CODA_CPP11 f36e2e1 protected -> private 21cfb2b rename PCRE -> Regex everywhere bace6dd rename PCRE -> Regex everywhere 38fb81d rename files 05faa44 style fixes 7d19a8b style fixes; convert mOvector to an actual vector 93b0e51 style fixes; remove unused USE_PCRE define; convert mOvector to an actual vector 031db11 fix type for Content-Type ca06e28 add ability to work with PCRE_DOTALL newline matching 5b43705 add "break" to kill infinite loop on error 5c42c95 add unit test for PCRE_DOTALL flag behavior adc62ea add second source file for C++11 std::regex, protected by preprocessor define __CODA_CPP11 git-subtree-dir: externals/coda-oss git-subtree-split: ba5cb1d337677474ba980dd2089045cb43bdb5f0
JonathanMeans
added a commit
that referenced
this pull request
Mar 3, 2020
215dc91 Merge pull request #174 from mdaus/prevent_fd_leak 57da17d Fix resource leak a3294b9 Formatting 5cd3dc8 Merge pull request #172 from mdaus/sync_externals 8aab47c Merge pull request #171 from mdaus/rsmida_tre_field 7d7e05c Merge commit 'b89884a99db23d0a69c465fbb2dd17d7dd173eb5' into sync_externals b89884a Squashed 'externals/coda-oss/' changes from 8995cd2c..16bdc9c5 83b06a7 Fix field name for Illum Azimuth Angle in RSMIDA 16bf5ea Merge pull request #168 from mdaus/remove_uncovered_warning b89e958 Unused variable warning git-subtree-dir: externals/nitro git-subtree-split: 215dc91
JDanielSmith
pushed a commit
that referenced
this pull request
Jan 22, 2024
3118941cc update various actions to latest versions (#608) f39321c67 latest from CODA-OSS 60952fb78 preload the remaining TREs (#607) 847101014 latest from CODA-OSS (#606) 09f2f458f use $(SolutionDir) to get to externals 3de4c5059 latest from CODA-OSS (#605) dc3a8ecf0 export more symbols (#604) 22f11f42b build as a DLL in Visual Studio (#603) 8d8184c27 NITRO can now build DLLs (#602) d3f58f038 added environment variable to enable pre-loading of TREs (#601) 85a113021 Merge branch 'main' of https://github.com/mdaus/nitro a1cec9cf6 Merge branch 'main' of https://github.com/mdaus/nitro 6801fa735 Merge branch 'main' of https://github.com/mdaus/nitro eca918471 /guard:cf 5d540334b /guard:cf de4686af0 improve TRE unitesting (#599) a4d0a5130 remove /Wall from MSVC (#598) b97c4a867 disable pre-loaded TREs (#597) 1075b4ecd be sure the string is properly padded for the field type a37046807 latest from CODA-OSS (#596) 205bf8e36 infrastructure for "preloading" TREs (#593) 0342b596a latest from CODA-OSS (#592) 0084f9bf7 reduce use of .str() (#591) 253f57b2b latest from CODA-OSS (#590) d6bc1d83a disable code-analysis to fix Github builds 981e75116 Update main.yml 907bf91cd Update frequent_check.yml 0357b1432 NITRO-2.11.5 (#589) a0ad6f943 CODA-OSS 2023-10-23 (#588) 1b631e578 latest from CODA-OSS (#587) 574bfe2b6 FmtX() -> str::Format() (#586) edfa0f7ce latest from CODA-OSS (#585) b26e15318 latest from CODA-OSS (#583) 0db9bdb29 fix ASAN diagnostics (#582) e418beceb Merge commit '6144b2cfb436a5696bab62c81651b47edf07aa8c' 6144b2cfb Squashed 'externals/coda-oss/' changes from 8dee6f7a68..c92a55d7c7 32d9c4fe4 latest from CODA-OSS 49f6338d2 latest from CODA-OSS (#581) 72cd86cbf latest from CODA-OSS (#580) e4920a743 FmtX() -> str::Format() 81ea6f178 Squashed 'externals/coda-oss/' changes from e87c32b4de..8dee6f7a68 e488297c3 Merge commit '81ea6f1789863f26f06dc447f7784383dc7cb595' 72209535d toString() changes from CODA-OSS (#579) fc1f59799 latest from CODA-OSS (#578) 02e8f80c6 latest from CODA-OSS (#577) e7ea728ec reduce differences between cpp17 and main branches (#576) 547d0aa9f NITRO-2.11.4 (#575) fe309c4ba Merge branch 'main' of github.com:mdaus/nitro 10efa9990 latest from CODA-OSS (#574) d08f1c0a1 CRLF db5d3d484 latest from CODA-OSS 98c755048 CRLF aa1482543 CRLF bfdbe69a4 Latest from CODA-OSS (#573) 9e4ce0b58 latest from CODA-OSS (#572) 227a8a8f4 trust coda-oss for right -std flags 13869687e latest from CODA-OSS (#571) 5724d8c18 latest from CODA-OSS (#570) fb794f0fe latest from CODA-OSS (#569) 7a6132ba0 update files changes in cpp17 branch (#568) de91d4977 Fix bug creating NITFException (#567) 225273436 fix YAML for 'main' 5d1c83d11 single project for unittests (#566) 102a019db latest from CODA-OSS (known broken build) (#565) b4ae2d429 match YAML from coda-oss 176bcaf6d build NITRO.SLN using msbuild (#562) 85e9043b8 latest from CODA-OSS (#561) 49ec50325 use new "PlatformToolkit" special environment variable (#560) 6c06e3711 latest from CODA-OSS (#559) cee9feb42 latest from CODA-OSS (#558) 3f01809fa latest from coda-oss (#557) 471fb3fc1 Update test_j2k_loading++.cpp b12caf2fc latest from CODA-OSS (#556) 0cd432624 use sys::make_span (#555) 05dae18a3 patch to build other projects 8f974e995 NITRO-2.11.3 (#554) 870aa6afd update to coda-oss 2023-06-05 (#553) 2fd7a0bfa latest from coda-oss (#552) 0eecce004 invoke() utility to reduce code duplication (#550) 59fb02fe9 latest from coda-oss (#551) 9fbf2b7b8 Fill out adapter free block which is used for nitf decompression (#549) 089ba0b5b latest from coda-oss 3b52f0025 latest from coda-oss (#547) 90c6263e2 latest from coda-oss (#544) 90d513ac5 latest from coda-oss (#543) 55a407b04 Squashed 'externals/coda-oss/' changes from ab45464820..e87c32b4de c8ecbe9ae Merge commit '55a407b04834573e5d6a1a1fb43d8c6a77608c06' 4fa700ed2 merge 'master' 6b9d2bac1 Merge branch 'master' 9ae5fec7d update to 'main' 342f55276 NITRO 2.10.13 (#542) f0cc26bdd latest from coda-oss (#540) 7d77233db latest from coda-oss (#536) 437978da8 latest from coda-oss (#535) eea09a38d latest from coda-oss (#534) e2f038e45 adjust compiler flags for clean CMake builds (#533) b871d2b9c latest from coda-oss (#532) e8ff6b444 apps: fix display of TREs from file extended header section (#529) 463c9e418 latest from coda-oss (#531) 24ff32863 -j 6 seems to work for SIX, how about NITRO? 713ee8538 -j 6 seems to work for SIX, how about NITRO? 4ccdf5b37 latest from coda-oss (#527) c71acc492 latest from coda-oss (#526) 08cbb96f9 build with older C++14 compilers (#524) e1a64da1f fix compiler warning a153ad562 latest from coda-oss (#523) bd741e4f1 latest from coda-oss (#522) 76047c7d3 merge develop/sync_externals 46c6702f8 NITRO-2.11.2 (#521) cd053bd7f coda-oss 2022-12-14 (#520) 28b65f4dc get unittests working in other projects (#518) 9182384db latest from coda-oss (#517) ab88a99f5 Merge branch 'master' b39ccc4c0 Fix conan build issues (#516) abbf7e318 remove .git directory right away 5be12fc35 merge develop/sync_externals 7306ac86a Merge commit 'cca64cca8a1061a11757abe3713c6ca25da31e45' cca64cca8 Squashed 'externals/coda-oss/' changes from 67d6362bcf..ab45464820 ffcce1e30 latest from coda-oss (#515) 52fe00059 latest from coda-oss (#514) 1d29e4d86 remove std::auto_ptr (#513) 29125a347 latest from coda-oss (#512) c37e01d87 update sync_externals.csh to pull from coda-oss:main fadf1b6a1 NITRO-2.11.1 (#511) 51c60eca3 coda-oss release 2022-11-04 (#510) 120e53b79 remove throw(something), deprecated in C++11 (#509) 103dd73ee latest from coda-oss (#508) 14eb5ec05 build unittests in other projects (#507) 4e02c8011 latest from coda-oss (#506) e12e6456b Adding tarfile member sanitization to extractall() (#505) f71128d6f Adding tarfile member sanitization to extractall() (#505) 89c954941 find known plugins (#503) 6f889c760 run unittests in other projects (#502) 1457afec3 latest from coda-oss (#501) 0c6f81732 fix some incorrect field sizes in the CSEXRB TRE (#500) 370221354 latest from coda-oss (#499) 8cda7dc49 HDF5 source code 72447c8d6 YML for "main", not "master" 0192c297d NITRO-2.11.0 (#498) c589cc8ca coda-oss 2022-08-30_cpp14 (#497) b902f29e1 fix merge conflict eba80ce74 Merge branch 'master' 61dafd407 NITRO-2.10.12 (#496) 06993176d run unittests in SIX (#495) f0d801e95 coda-oss release 2022-08-30 (#494) 8477e4729 Build jpeg decompression as a plugin. (#487) c0abba06a Merge branch 'master' 59978233a latest from coda-oss (#493) 54340035e Merge branch 'master' 53bbc6679 latest from coda-oss (#492) 179223ed8 Revert "-std=c11 for Linux?" 708179860 -std=c11 for Linux? 3a2ff608e main is now C++14, not C++20 489441b8c Update CMakeLists.txt 25f8fd749 use GCC-10 9a9ac37a3 restore changes lost in merge 2425e9910 Merge branch 'master' 77a1114eb NITRO 2.10.11 (#491) b5fb2d2a9 another round of removing compiler warnings (#489) 2342edbef coda-oss 2022-08-02 (#490) 46ea890b2 Merge branch 'master' 7e1fe6a68 NITRO-2.10.10 (#486) 263a98cfc coda-oss 2022-06-29 (#485) 67e80024d latest from coda-oss:main 54ba70a09 Merge branch 'master' a3bb3a032 nitf::byte is too much trouble right now (#484) 53a75a456 nitf::byte is more trouble than it's worth right now a1fbcbde7 Merge branch 'master' 8d28243d2 update CodeQL to @v2 (#483) 7091d36a6 Update coda-oss (#482) f40179473 return std::optional<> from "enum" utilities (#480) 3972dba9e update coda-oss (#479) 96a93af52 get CODA_OSS_API from "master" 7d7a31b9a Merge branch 'master' 3e38c39a0 latest from coda-oss (#477) f27a3894e Do not add convenience test targets if given the libs_only flag. eb6e6a0b9 latest from coda-oss:main c32542292 Merge branch 'master' ed0d1899b NITRO-2.10.9 (#476) f4eacccaf coda-oss release 2022-05-03 (#475) 4baedca72 turn off "warnings as errors" for now 1938e8b2a C++17 has non-const std::string::data() 8743b133e Squashed commit of the following: a0cf3e90e Merge branch 'master' 758ac88e1 latest from feature/j2k branch (#474) 55eeba9fc build with C++20 4c93d6d3f Merge branch 'master' b8a3f5076 tweaks to allow NITRO modules to be built as DLLs (#473) af745281c latest from feature/j2k branch (#471) a7da2fc74 build more C code as C++ (#469) 5dbd0d9cd latest from coda-oss (#468) e9b611e23 build cleanly in VS2022 06ccfd635 "warning as error" from master b60d152db Merge branch 'master' 3e9387973 add lossy compression options (#464) da6969ae0 latest from coda-oss (#465) bd8ce8116 build most C with C++ (in Visual Studio ONLY) for better error-checking (#466) dfeb3fe44 remove docs directory (#463) 2d52cf3f6 remove archive directory (#462) d9f75ef70 Merge branch 'master' 5b11fe82c copy j2k code from coda (#460) f02c70645 merge develop/update_coda-oss 8907b9fc3 latest from coda-oss (#461) 1124c00f9 switch VS unit-test projects to VS-test (#459) 8968e3fc8 build in "main" 04b0ef4a0 delete files in "out" directory c12cf79c8 Update NITFException.hpp 47adca89f latest from coda-oss:main dcf564587 Merge branch 'master' c6e7a6e40 Merge branch 'master' of github.com:mdaus/nitro ed828aaf6 fix CodeQL diagnostic 762b2a2ce NITRO version 2.10.8 (#456) 466534fd8 begin work in C++ wrappers for 'j2k' C API. 3b72561d2 update to coda-oss release 2022-02-22 (#455) c0c8d4f71 latest from coda-oss:main d22382c6e Squashed commit of the following: ba35e18cd Merge branch 'master' 3f70bc3c3 latest from coda-oss (#454) 7746990ab latest from coda-oss:main 4e556856b Squashed commit of the following: b252f8334 Squashed commit of the following: ba1586d87 Merge branch 'master' 8a8ea90b0 build with older C++ compilers, compile C as C++ (#453) 96ef07b45 Merge branch 'master' 9690f9076 update coda-oss (#451) ee85f16b2 make our C and C++ versions "requried" e5fb00b73 Merge branch 'master' 1d307d9aa latest from coda-oss (#449) 2bd17b15d Merge branch 'master' 6861d915a std include files got messed up c71dc6d85 latest from coda-oss (#448) ff26970eb be sure variable is referenced ba7cf4db1 Squashed commit of the following: 73f9426aa latest from coda-oss:main c6e6efbfd Squashed commit of the following: f8b70cfd6 Merge branch 'master' db9f1d2a5 account for missing std::is_trivially_copyable<> (#446) 7581fe17d latest from coda-oss (#445) d991a0494 infrastructure to support "reflection" over C structs (#444) e04238a27 Merge branch 'master' edaf47f81 show how to use strongly-type TRE fields (#440) 8af36f6ed latest from coda-oss (#441) fe89ce317 Re-add show_nitf++ app (#439) 2433d8c5f Squashed commit of the following: b3d0e3993 Merge branch 'master' 9ea44741d nitro 2.10.7 (#436) 458055cfc coda-oss release 2021-12-13 (#435) d4ad4b8a5 allow NITF_PLUGIN_PATH warning to be turned off (#434) 5bc7a39f0 Merge branch 'master' 7c96994a9 allow NITF_PLUGIN_PATH warning to be turned off (#432) 1b22d00a6 latest from coda-oss (#431) a26f5b104 Squashed commit of the following: 6d375adea try again with Exception11 3528797b3 Revert "try again to use Exception11 as base class" 1940761ae try again to use Exception11 as base class 494c66e5b Squashed commit of the following: aec5ac588 Squashed commit of the following: 85115cf26 Squashed commit of the following: 10e82f255 more work needed to use Exception11 as base class 832c08190 can't get rid of the Throwable overload aafa78ac9 Squashed commit of the following: 4538afe97 Squashed commit of the following: 454389ab4 use Exception11 as base class 63c6c7aab Merge branch 'master' 489f10d70 tweaks from develop/jdsmith (#426) c8b635070 Merge branch 'master' 9461c626c latest from coda-oss (#425) 13755f97e Squashed commit of the following: f24599625 Squashed commit of the following: 3cd04a52e Squashed commit of the following: 37a3d372f Merge branch 'master' 2e8d7cfae tweaks for new compiler on Windows (#424) d3df338e9 Merge branch 'master' e868e3747 build with VS2022 (#423) 88135e2c2 Squashed commit of the following: 8716407f1 Merge branch 'master' 65b4df02d Build with Visual Studio 2022 (#422) 75cd78027 C17 and C++20 cd35ce559 Squashed commit of the following: 741570885 build with Visual Studio 2022 5aca0a352 use G++-10 051cba7c4 compile with C++20 4df16ef7c latest from coda-oss:main (C++20) 9cd6642fc build with C++20 09294e4a6 Squashed commit of the following: b551da471 C++17 changes from coda-oss 029245e92 Merge branch 'master' 64dc4e118 -j 2 to prevent G++ crash 64ec3748c try -j 2 for faster build c4e122edf include all of coda-oss (#421) adc119faf spaces, not tabs d8de25452 trying to fix broken cmake build 9dbe61e7e Merge branch 'master' 888ae9293 update version numbers before cutting a new release (#420) 28d95160e Tweaks from SIX's 8AMPI_PHSI branch (#418) a0dd912a9 latest from coda-oss (#419) b782ea5e1 remove #pragma once from CPP file 0bcd29d66 fix std/bit for C++20 dfba5e291 fix CodeQL failure (#417) 77b3b6e4a Merge branch 'master' 3c7653c3e make building as a DLL easier (#416) 42f309c76 try C++20 for CMake a184c5643 Merge branch 'master' e17d918d4 read in 8-bit sample files using NITRO (#415) b78673982 use strongly-typed enums rather than overload strings (#414) ffd0cb43a build with C++17 d7fec1ee6 C++17 ba356b0aa Squashed commit of the following: dfde87258 slam in "master" 479166465 Squashed commit of the following: 89559fa88 want C++17 in "main" 9c318935c Squashed commit of the following: 6fe42fbc8 Merge branch 'master' 30fc68feb latest from coda-oss (#413) a4a1fc4f8 add a NITF version number (#412) eef3c6ec8 update coda-oss (#411) f5f1f8ce1 "nitro" changes from SIX (#410) 1a19b6b60 latest from coda-oss (#409) 0db498f1e make the TRE API more robust (#406) 404a857ca Bugfix/engrda (#405) 1c73a5284 latest from coda-oss (#404) 9388d5cf2 latest from coda-oss (#402) 9578bcf83 Handle amp-phase data (#403) 81278527b remove compiler warnings that were clobbered by a previous merge (#401) 3ebffd877 update coda-oss (#400) c8186387f tweak C++ API (#399) dc000a516 latest from coda-oss (#398) 7af555d63 latest from coda-oss (#396) cb37a8cff remove compiler warnings (#395) 1b6cfe099 latest from coda-oss (#388) 2229fbde0 forgot to add "units" to CMakeFiles.txt e1a1bcefa latest from coda-oss (#387) 835da56f5 Bugfix/nitropy import error (#381) 508ee3e75 Fix invalid const cast error (#380) fb293c1a2 build with something more recent than C89 10712fc6b got copy-paste wrong 859010c9f back to C++17 for now b21178125 Merge branch 'master' into main 7bb82996c update coda-oss (#378) 98e6bcf5d remove more code-analysis diagnostics (#377) eaf109eb4 C++17 fix from coda-oss 0d97539b9 almost build w/C++20 8eb0ef76b build with (almost) C++20 bea6db32f Merge branch 'master' into main c3dc82205 update coda-oss (#376) 7acaf38ed match "master" 172714e33 #pragma warning is _MSC_VER only ffd5aa858 Revert "do a Debug build on Windows" 5d84be10c do a Debug build on Windows b1683ea11 Merge branch 'main' of github.com:mdaus/nitro into main 9b928303a build cleanly in VS2019 2940ec159 refresh from "master" 62e3bdce7 Merge branch 'master' into main e6cfbfab8 make parts of the C++ API a bit more python-like (#375) 9194eb0d3 Merge branch 'master' into main 75caf49ec remove compiler warnings/code-analysis diagnostics (#374) a6cec9dfe update coda-oss (#373) f4b80a31d reduce compiler warnings (#371) ac4141ddc Merge branch 'master' into main 4ddaf23d8 remove compiler warnings (#370) 2a57741c2 update coda-oss (#369) d36c562f3 Merge branch 'master' into main d3fab714a update coda-oss (#368) 8806960a8 tweak to force rebuild of "master" on github 9aee934ea remove compiler warnings (#367) 7be6c13b1 set an "invalid" string result for invalid inputs (#366) d4f244ee8 remove more compiler warnings/code-analysis diagnostics (#364) d01179540 latest from coda-oss (#363) a16f72b0c make it easier to build nitf-c++ as a shared library (#362) 35c5f4ade reduce compiler and code-analysis warnings (#361) 273c39e86 latest from coda-oss (#360) b6b38054d Merge branch 'master' into main 298536f40 remove unused coda-oss modules to fix? broken build (#351) edb9317db Update README.md 152b1d66a Java and MATLAB bindings are no longer built. 2748224ba unittests work from clean build in VS2019 (#347) 296750e1d Delete codacy-analysis.yml 2121cda37 Delete checkmarx-analysis.yml 393b6cd55 Create codacy-analysis.yml a01fa4d6f Create checkmarx-analysis.yml effd34006 fix more CodeQL diagnostics (#346) e145375a7 Merge branch 'master' into main a2b3a12d9 Fixed bug in python interface, and enabled a few features in the c library to be accessible from python (#342) 1e171cdfc remove code-analysis diagnostics (#345) fa4048001 Merge branch 'master' into main c68cd17dd latest from coda-oss (#344) 4ff3782d4 latest from coda-oss:main f455459a3 Merge branch 'develop/update_coda-oss' into main daf11b09b latest from coda-oss b2ee4c0cc Merge branch 'master' into develop/update_coda-oss 6dc6856db Merge branch 'master' into main bb0634924 update coda-oss (#343) d46965774 latest from coda-oss 875900215 Merge branch 'master' into develop/update_coda-oss c83d97832 #pragma-away warning from <complex> b7d7a7fa8 this branch builds with C++17 f015b5c98 Merge branch 'master' into main fa20f42ee use new coda-oss header for easier access to "std::" (#341) eae673f69 tweak std:: handling from coda-oss fe3129e92 std:: changes from coda-oss c8b1b7f9b and still more coda-oss updates e4b655cea another update from coda-oss 32e14a957 latest from coda-oss d64174882 Merge branch 'master' into develop/update_coda-oss c80e163ee Build w/older compilers; remove some code-analysis diagnostics (#340) dfad79efc Delete ossar-analysis.yml 007ced759 archive matlab and java (#293) 0e201d8b0 Create ossar-analysis.yml c4eae8e4c Create codeql-analysis.yml ea1946b4a Delete codeql-analysis.yml e40a0b3f6 add ENABLE_ASAN to turn on address sanitizer (#336) 2d9a968f2 fixed a bug where an uninitialized pointer caused a crash (#335) 7c5dbed7f `nullptr_t` should be `std::nullptr_t` e38e05bb2 Merge branch 'master' into develop/update_coda-oss 612a55889 remove version number from externals/coda-oss (#333) 4eb99576b missing "build" and "cmake" directories f99a8e343 rename "coda-oss" c36f316d0 restore coda-oss 3a94197a8 do rename (again) 2b1c237d2 Merge branch 'master' into develop/update_coda-oss c14639765 nitro doesn't need "re" module (#332) 03ff84a4b missing "build" and "cmake" files 25eb45608 get red of the version number (for now); we've been w/o for a very long time 14517c04f put a version on externals/coda-oss (#331) d6b87a252 add back .cmake files 0827cf5a5 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss f62735eb5 add back build directory daaf0f7e0 Merge branch 'master' into develop/update_coda-oss 8705bbb63 C iterator routines can be "const" (#330) f26f1f916 externals/coda-oss is now a junction or sym-link 4a3200ade rename "coda-oss" to include version # ee54fff15 Merge branch 'master' into develop/update_coda-oss f77a3820d Merge branch 'master' into main 62ec49119 update coda-oss (#326) 4d4c9b252 latest from coda-oss c93726279 Merge branch 'master' into develop/update_coda-oss b7f04aecb fix broken unit-test; implement missing overload (#325) bebfbab20 Merge branch 'master' into develop/update_coda-oss f810f8f6e Fix length calculation for moveTRE and unmergeTREs (#324) ad0f83a6f Null init Image writers (#323) e77ddad8f CMake: Build c libraries, in Windows, as DLLs (#321) bdf37cc45 Merge branch 'master' into main 7a8dcf296 update coda-oss (#322) d100a7d28 latest from coda-oss to build with older compilers 82afef8fd Merge branch 'master' into develop/update_coda-oss 333b82189 Merge branch 'master' into main f0a45b36d latest from coda-oss (#320) d277cb432 revert c99 changes (#319) f1a76a95a latest from coda-oss a8692278d Merge branch 'master' into develop/update_coda-oss ae5aefa1a Merge branch 'master' into main 1b6ae6adb hide template<template> from C++11 (#318) e510f3d7b Merge branch 'master' into main ee89c7d34 Bug fixes, new TREs, and cython interface (#314) af9135656 Merge branch 'master' into main f925204cb revert c99 changes (#317) 2f0d13fed Merge branch 'master' into main dc2bfc2f6 Merge branch 'master' into develop/update_coda-oss 1615ce17b update coda-oss (#316) ad0136140 don't need .github in "externals" 31e42bbae latest from coda-oss 1cd6b1e22 Merge branch 'master' into develop/update_coda-oss bbe02cde3 build with C++17 in this branch 905abbff8 Merge branch 'master' into main 0fbebcbdc update coda-oss (#313) 88cd12dc4 latest from coda-oss 6bc7a365c Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss 8b51116b8 Merge branch 'master' into develop/update_coda-oss 91cb40798 std::filesystem::path doesn't implicitly convert to std::string 287ad87bd latest from coda-oss 9ab0959a6 try harder to compile with C++17 6fb07547f can't figure out how to install later version of g++ 37738180f trying to install a more recent version of g++ 5c7bafa59 spaces instead of tabs cce8fa221 install the latest g++ 5e8545d65 Merge branch 'master' into main 280141628 fix errors/warnings from code-diagnostic tools (#312) f419dc538 Update .gitignore for CMakeSettings.json bc379d3f7 build with C++17 in this branch 9bee8c38f Merge branch 'master' into main 2d73f0ee1 latest from coda-oss (#311) d01c82540 latest from coda-oss 1a3e65cb3 Merge branch 'master' into develop/update_coda-oss 4a51148c7 build "main" with C++17 979b11ff3 Merge branch 'master' into main 0d6988eb1 latest from coda-oss (#310) a7849538b don't need to change coda-oss drop 33cf616e4 gsl::span -> std::span b229bead9 latest from coda-oss:master 29a88056b get coda-oss #includes via coda-oss.hpp to augment "std" (#309) 5e60c0959 Merge branch 'master' into main 5be4b7e63 "noexcept" is a breaking change ... be more careful with it. (#307) 63ee18c41 Merge branch 'master' into main 92b19f9c5 remove nitf::byte (#306) 657d5a1da Merge branch 'master' into main 9045a98d9 slam in "master" (again) to minimize merge conflicts 08dd5441f restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" 554f1c1b5 manaully update "main" with changes from "master" to minimize merge conflicts c1ef1e933 bring over non-breaking changes from "main" (#303) cf559b109 update coda oss (#301) 1d91f312e latest from coda-oss (#300) e6448b1dd tweaks so that six builds with nitro updates (#299) d27779eb7 std::byte -> nitf::byte until we can use C++17 everywhere (#298) 413fadf3a Update .gitignore 5c6a2ef68 update coda-oss (#297) 8bb4d248c build with Visual Studio 2019 (#295) 698841c86 get unittest changes from main (#294) 9a29ce5f9 latest from coda-oss:master (#291) 67d325690 reduce compiler warnings and the like from C code (#292) 38295eda4 latest from develop/jdsmith (#290) adc0e73fe latest from develop/jdsmith (#289) 918ec5182 update coda-oss (#288) 9946049f4 use GSL from coda-oss (#287) 75ccefa3d latest from coda-oss (#286) b6f883fc1 latest from coda-oss (#285) 16289ae3b update coda-oss (#284) bce3916ac one more change from develop/jdsmith (#283) 09eaf7266 latest from develop/jdsmith (#282) ff3ca9dcb update coda-oss (#281) 2b0e059f3 increase use of range "for" (#280) 8bde69680 latest updates from develop/jdsmith (#279) b545a6101 latest from develop/jdsmith (#276) aa13b3a62 Feature/update coda oss (#277) bed0e2526 int64_t instead of sys::Off_T (#275) 07f8d9a62 latest from develop/jdsmith (#274) 8a97faadd ... still one more "common" use-case. e5b270a9a ... and one more overload for a common use-case 30b249258 restore SegmentMemorySource() overload to avoid breaking too much existing code a7b77e86a more use of std::byte (#273) f1b67ffaf use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) da88a43a6 move real GSL code to a place where it will be copied by existing scripts (#270) 19ed66f86 Feature/remove compiler warnings (#271) d8f1f8c5c build show_nitf++ in VS2019 (#269) 57f5aa5c8 remove compiler warnings (#268) c6407b8b6 remove compiler warnings (#267) 09c201636 GetEnvironmentVariable() and getenv() aren't quite the same be7174a70 use top-level WAF install directory rather than externals (#266) f07461b69 remove compiler warnings (#265) 00a0a7819 remove dozens of compiler warnings (#264) 3d65ba13d tweak wrap-around results (#263) c7601b742 fix wrap-around values (#262) f5c557412 remove compiler warnings (#261) a1022e1c8 latest coda-oss from "main" (#260) 35254eb83 get unittest working with WAF on Linux 7e371459c fix unit-test for WAF on Windows 70755443a latest from coda-oss (#259) d141017fb remove coda-oss modules not needed by nitro (#258) 3ea4b8313 latest from coda-oss (#257) a9bf63fb9 update coda-oss (#256) c5f2e5e0e latest from develop/jdsmith (#254) e1ff1e8aa move "mex" and "java" to an archive folder (#255) 045718acb Feature/update coda oss (#251) 0be5b5cc4 update coda oss (#250) 8ffdeaf11 wlhen building SWIG code, C-style enums are used fe4f6c9ef need C-style enum with SWIG & build XML_DATA_CONTENT (#249) 621bba7df latest from coda-oss to remove code-analysis warnings (#248) bacedbba3 fix Field to be compatible with existing code 572531c18 build new TREs w/CMake (#246) c126d5d39 Add four TREs defined in MIL-PRF-89034. (#192) 5c8c30b1c build new TREs w/CMake (#246) 4efc97eaf Add four TREs defined in MIL-PRF-89034. (#192) 839b51f63 remove compiler warnings (#245) 42e35f33e tre: add MATESA support (#244) e13921039 tre: add MATESA support (#244) fa37bc21c Create codeql-analysis.yml 7e9b93f71 Create codeql-analysis.yml 505dea66a update coda-oss (#242) 79bc5e06f java: update to supported version (#241) eaafd58a1 java: update to supported version (#241) d5df4ba25 display TREs from other parts of the file (#239) aa8d3aa57 Fix bug with myResidual calculation (#204) 59afdc92e Fix bug with myResidual calculation (#204) 2fb1833dd build with Visual Studio 2019 (#237) 8251e9a23 get some more "const" correctness changes (#238) 4b3ac6de3 make many more "getters" const (#235) f99755a37 write out the TREs to XML (#234) b8c0cdf7a make a bunch of "getters" const (#233) ee745cb88 Revert "Merge branch 'master' into main" e49019378 Merge branch 'master' into main 050fcbc96 Fix assorted compiler warnings (#232) 6d77fb41e Fix assorted compiler warnings (#232) 11704d375 update "documentation" (#231) cad5c02f9 update "documentation" (#231) ae2c21c9b use our own str*_s() routines (#230) bb814d464 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) 0fb160719 Revert "merge "main" into "master" (#224)" 1c7aa6653 Merge branch 'main' of github.com:mdaus/nitro into main 0faaa0165 merge "main" into "master" (#224) 3031b6507 trying to fix compiler crash 9183dcb88 grab a few tweaks from develop/jdsmith (#223) cc9956b2d develop/master -> main (#221) 1437badef Develop/main (#220) c13a2e0d2 Merge branch 'master' into main 5579e74e8 update "master" with several changes from "develop" (#219) 5988bb529 don't build "macos" ed0063048 coda-oss doesn't build "macos" so we don't either (#218) 903686414 update "main" with latest "develop" changes (#208) c1ddf4cde Feature/update coda oss (#217) d77737f5d update coda-oss (#216) c5c602dd0 update coda-oss (#214) 033220f92 latest coda-oss from master-C++17 (#212) 7caacb941 copy some documentation from the old website; work-in-progress (#211) 0f0d05404 Feature/remove compiler warnings (#210) 9a609577c Feature/use standard c types (#209) c83348fd3 ignore more build artifacts 3bb1ef02e Merge pull request #205 from mdaus/bugfix/Security-vulnerability-in-nitro 9757b5af5 fix a bunch of code-analysis warnings about using NULL pointers (mostly … 6b72b7c37 fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) 22716b796 be sure local variables are initialized for all code paths c0b7b38b9 no .vcxproj in this branch 40d66294a fix some build warnings 362b5492e build with VS2019 CMake support 496bfba71 Merge pull request #200 from mdaus/DisableComponents 8b375e6ae Make some parts of the nitro build optional for CMake 038069b2e Merge pull request #199 from mdaus/cmake-integration2 83efec019 Fix another Github Action runner issue. c1624a252 Fix CMake issues for Github action runners. 9de7b7826 Clean up and document CMake build changes 8947c15b4 Merge branch 'master' into cmake-integration2 d05822e9c Merge pull request #198 from mdaus/sync-externals 34b538e15 Merge commit '1262718741583c73dbf27057a7c322ea1fac0fae' into sync-externals 126271874 Squashed 'externals/coda-oss/' changes from 312e46dc..67d6362b 6a1b1946c Remove some unneeded coda-oss files 86598e258 Disable some unused parts of coda-oss a181098c5 Update Github Actions workflows for recent CMake changes. 48e620397 Update and refactor CMake and Conan build configurations 06be9b568 Fix Conan issues on Windows b7a62f5f0 Refactor Conan configuration and add test_package. 9a7688da6 Add preliminary Conan support. dfe87215d Refactor CMake build. 6732f92a0 Integrate with coda-oss CMake build. 800953f46 Merge commit 'df7acfb8e80f33d2f04d0ec8c4efbd8b2317826f' df7acfb8e Squashed 'externals/coda-oss/' changes from e26a32d6..312e46dc 9a8f5fe13 Merge pull request #197 from mdaus/bug/badly_configured_windows_path 793555754 Escape backslahes in Windows path 445c1e260 Merge pull request #195 from mdaus/bug/des_memory_leak 2906a6384 Check in Python3 bindings 4293cc465 Formatting aa3455aac Merge pull request #190 from mdaus/bug/failing_ctors 8c7b5c7fa Better error checking c545a423f Merge pull request #191 from mdaus/missing_field_error_message aead30a84 Include TRE field name in error message 32e8e23be Formatting 627c183d2 typo cabca936d Simplify error handling 2d0bb8ab7 Formatting 7f8794c37 Merge pull request #187 from mdaus/bug/tre_numeric_overflow 251bde556 Merge pull request #183 from mdaus/tre_memory_leak d1ab7ec53 Merge pull request #185 from mdaus/bug/set_binary_tre_field 67b50288e Handle too many decimals when setting float value for TRE field d4776de1c Use error member 86528d669 Uncomment test a4d1acc34 Allow setField to work with binary TRE fields 0e0b0dac0 Fix memory leak d172d74a7 Merge pull request #181 from mdaus/sync_externals 7036b6307 Merge pull request #179 from mdaus/bug/silent_tre_error 0bb051ceb Squashed 'externals/coda-oss/' changes from 16bdc9c..e26a32d d04dd53f9 Merge commit '0bb051ceb0c16e00bd766320676689c0437829e7' into sync_externals 9ef937b46 Throw if setting TRE field fails 8c0dca54e Formatting 5ed533018 Merge pull request #178 from mdaus/update_version 07ad946f5 Regenate python bindings 1a695a1db Remove useless setup.py 8875dc6d9 Update NITRO version d2bf2fc26 Merge pull request #177 from mdaus/better_path_for_binary_release e28ad0e28 strcpy -> strncpy 66ffd0ac8 Merge branch 'better_path_for_binary_release' of github.com:mdaus/nitro into better_path_for_binary_release 32376376e Formatting 202fb6562 Formatting 7aad17fec Formatting 88769f7cf Update README 1f026c23e Compiled-in NITF_PLUGIN_PATH will not help users of binary release. Remind them to set NITF_PLUGIN_PATH if they need to 83f8e8807 Merge pull request #176 from mdaus/fix_jenkins 365f859c6 Remove useless pp-macro wrappers bb3746577 Check-in generated code from waf build to keep Jenkins happy until waf goes away 227dc9d07 Merge pull request #175 from mdaus/cmake_build 30c24d151 Get correct type for version 7baf850b7 Simplify handling of xml module d95e1ef75 Pass waf install target in single command dfed19154 Merge branch 'master' into cmake_build a1db4f295 Update README with state of CMake build 215dc9112 Merge pull request #174 from mdaus/prevent_fd_leak c6519629c Merge branch 'cmake_build' of https://github.com/mdaus/nitro into cmake_build 4c79a3ab0 Fix Windows build 23128ab89 Fix install command for MATLAB 57da17d65 Fix resource leak a3294b993 Formatting d7f40ddd0 Fix SWIG flags 465c4bef4 Formatting d4cc2ac2e Fix building TREs 197ce0599 Resolve merge conflict 546e6226b Merge branch 'master' into cmake_build 5cd3dc82f Merge pull request #172 from mdaus/sync_externals 8aab47cfd Merge pull request #171 from mdaus/rsmida_tre_field 4a9ef40f6 Merge branch 'cmake_build' of https://github.com/mdaus/nitro into cmake_build b89884a99 Squashed 'externals/coda-oss/' changes from 8995cd2c..16bdc9c5 7d7e05ce0 Merge commit 'b89884a99db23d0a69c465fbb2dd17d7dd173eb5' into sync_externals 5d81a5f40 Allow separate CODA home c3caae773 Handle case where CMake can't find Python interpreter ea3ebe3d4 Fix checking for Java 16362b5e3 Fix cgm-c target name ae14a8d03 More consistent module names 83b06a79d Fix field name for Illum Azimuth Angle in RSMIDA 5e5cd7e8d Clean up handling coda modules and common logic af5941558 Recurse into all directories 28841aa44 Add MATLAB layer 4678a5244 Add Java layer c49b41c2b Add CMake for Python layer 16bf5ea98 Merge pull request #168 from mdaus/remove_uncovered_warning ef75df708 Merge pull request #167 from mdaus/github_actions 0cdbfdf89 Add extension ffc5d12f3 Add mac runner b89e9584b Unused variable warning 01f3172ed Add job for every push 1e9c27035 Only archive for master 4ff35c18b Merge pull request #166 from mdaus/sync_externals 92f75549c Better name 6af9dbb76 Don't need ls 570071a23 Upload Windows install 77f6da166 Fix paths 232e3e441 Grab files from build dir 1f487b214 See why we can't tar the install dir bca53e41d Fix CMake invocation 01e796e39 tar up release on linux 598b1d658 Parallelize build 784b96533 Add Linux build step 55ee37d8a Directory diagnostics aae07e9e8 powershell doesn't like && 38591d0cb Try CMake build fa452e924 Merge branch 'sync_externals' into github_actions 6bda0a951 Try running on windows 1aaa96e33 Squashed 'externals/coda-oss/' changes from e3e70cf..8995cd2 d66c86041 Merge commit '1aaa96e33f5f20199e137b10fa3d6c6b763c3729' into sync_externals 77b70a102 Try just running on ubuntu 44dfe5b92 Typo 4a0738a47 Merge pull request #165 from mdaus/cmake_build a0644de76 Add sample cpp workflow 6aac84c16 Merge branch 'cmake_build' of https://github.com/mdaus/nitro into cmake_build f4766e959 Fix building TREs on Windows 735dd2f62 Update README 2ac410581 Make sure compiler actually supports C++11 ab3747fd2 Force building CODA-OSS before NRT so we can use the config header 7778989cc Just reuse the coda-oss config to avoid symbol redefinition 81f06cc51 NITF_DEFAULT_PLUGIN_PATH should be public da784ab72 Dont generate config files in source tree 17ed9355f Fix Windows build c7a30575f CMake build for c/c++ modules 5523c44cc Fix some warnings 583e7c9e5 Merge pull request #164 from mdaus/sync_externals d2d1dadb4 Merge commit 'd2cdf6d3d6384b12df6b00bb13160b459fb65433' into sync_externals d2cdf6d3d Squashed 'externals/coda-oss/' changes from d5dafc3..e3e70cf 89e4f43e9 Merge pull request #163 from mdaus/default_nitf_plugin_path e8ffab774 Use compiled-in NITF_PLUGIN_PATH if environment variable not set 77a2c2b66 Format PluginRegistry.c c0d9939a8 Merge pull request #162 from mdaus/jenkins_script 9f91a90b9 style c4cae2f3d More comments; remove debugging code c99cbc8fa Merge pull request #161 from mdaus/fix_subheader_length_checks 0be2452eb Add dbugging f0b8a3070 Compare against regression files 1ba3d7914 Add script for Jenkins regression test 9b1cd6e3a Exclude DE segment from SE subheader size calculation 3bce1fb8f Merge pull request #160 from mdaus/revert_copy_constructor ba2d1b655 Revert "Merge pull request #159 from mdaus/band_info_copy" f2ee1678c Merge pull request #159 from mdaus/band_info_copy 9b57e5884 Don't need to adhere to archaic C90 rules in C++ layer 8215881b7 Proper copy semantics for C++ BandInfo 3f51d12e5 Merge pull request #157 from mdaus/size_checks a34f45fae More consistent naming f1fe28a4b Add sanity checks against garbage length values when reading 29fe312c9 Merge pull request #156 from mdaus/sync_externals 5a0b89344 Update checked-in Python bindings to use Python3 21b1bae09 Update CODA-OSS 94a0dd68c Merge pull request #155 from mdaus/check_nitf_from_stream 07cf5f7ab Add overload to get NITF version from an IOInterface 8e598b29c Merge pull request #152 from mdaus/sync_externals db2bd216f Replace header 5049aeb61 Squashed 'externals/coda-oss/' changes from 0efc30c..d5dafc3 8c2393060 Merge commit '5049aeb61891a8297c756b27841e2f227fe961f7' into sync_externals 690346165 Merge pull request #151 from mdaus/sync_externals 91e7d1ae2 Squashed 'externals/coda-oss/' changes from 4995c9e..0efc30c 7360c647c Merge commit '91e7d1ae2034a182b88c3700fe83a1e4e6cf1f7d' into sync_externals abe6ee5fe Merge pull request #150 from mdaus/remove_test_warnings c7d92fa82 Remove warnings 64fa9722e Merge pull request #149 from mdaus/shared_build_fix e8abef5d2 Merge pull request #148 from mdaus/sync_externals 8575413be Build CGM f266587bf Cleanup d248ef3be Add VS dirs to gitignore 75022cb9b Cleanup a6f5d69c6 Cleanup d30fb8af0 Fix indentation 346236c8d Merge commit '24048fe232bca15801857cf5a2de1f703155cf77' into sync_externals 24048fe23 Squashed 'externals/coda-oss/' changes from eee482d..4995c9e 8e05b6456 Add jpeg shared library 7c87020d1 Build DLL for j2k ff1462a14 Merge pull request #147 from mdaus/sync_externals 373cbaf9b Squashed 'externals/coda-oss/' changes from 7e0a53e..eee482d 218e8773f Merge commit '373cbaf9b839f6d7c1bcda12c299bfbbf8e400c0' into sync_externals a863cf0eb Merge pull request #146 from mdaus/fix_multiband_nitfs 09da5615c Clean up tests bee1c810e Fix copy/paste bug; add test for 16bpp data 04afc7df0 Merge pull request #145 from mdaus/fix_multiband_nitfs de2a8b2ba Strip trailing whitespace e4d655e2f Cleanup 1f646f6e1 Enforce band order c9d7b873e Old C limitations ffdf6eda7 More failing test cases 7d3839796 Make fewer assumptions about bandlist order bbaadc5b8 Finish fixing Multiband P read d19069f9b Quick workaround for testing cb7091ec4 Fix test; add failing test for buggy case 614c607de Fix formatting and tests eab11faeb Merge branch 'fix_multiband_nitfs' of https://github.com/mdaus/nitro into fix_multiband_nitfs 263824f39 Draft failing test and regression test c4f861d5a Misc cleanups 69aab7b3e Merge pull request #143 from mdaus/fix_multiband_nitfs 9eff3a157 Regenerate Python bindings; rename test with name conflict 5382800b7 Disallow direct block write for multiband images bbd316f44 Handle unexpected block size 4d1560543 Merge pull request #142 from mdaus/sync_externals b9fb90dca Squashed 'externals/coda-oss/' changes from dbabd95d..7e0a53e4 253b03601 Merge commit 'b9fb90dcae51d25cd6cb0b3ec7f9cf514d09da8f' into sync_externals a9a86b199 Merge pull request #138 from mdaus/sync_externals 18fc2b814 Squashed 'externals/coda-oss/' changes from 163168f..dbabd95 50a541f79 Merge commit '18fc2b8147553d0fbf899faa79739242132bde4d' into sync_externals 251690808 Merge pull request #137 from mdaus/faster_field_modification ee142aaaa Fix formatting 4de6cd570 Fix copyright date 46177d3ef Only populate fields as needed 319380a4a Merge pull request #136 from mdaus/ExceptionSpecRemoval 76f4c1c98 Remove exception specifications. 7ddc27bfb Merge pull request #135 from mdaus/buffer_adapter_bug 7c4f902e7 Fix BufferAdapter_getSize c4d72a594 Merge pull request #134 from mdaus/buffer_adapter_bug d655f07cb Don't cast memcpy args 4749d2cd7 Fail reading past EOF 05096c1e7 Add copyright banner 3d2ea8064 Remove trailing newlines 1d46c77b5 Add test for writing b1b58fc06 Update BufferAdapter to seek past EOF like Unix and Windows interface d914c9a79 Merge pull request #133 from mdaus/ImageIO_memory_issues 9cb48e8f4 Remove memset 728f9755b initialize bPixelOpen buffer to NULL 4044c3d9b Fix style issues dd98d39cd Fix memory issues in ImageIO.c ba7e95e21 Merge pull request #131 from mdaus/sync_externals e6909024b Merge commit 'c5f38cf8bca8283e43da93f723ad8c33e3bc8b0b' into sync_externals c5f38cf8b Squashed 'externals/coda-oss/' changes from c5cf45e..163168f 9bb244b06 Merge pull request #129 from mdaus/mstgta_typo 7646a64bf Fix typo is MSTGTA.C be04d0db8 Merge pull request #126 from mdaus/msvc_upper_bound_bug b045be4e1 Remove incorrect version check 122e14685 Merge pull request #125 from gpotts/master d699d5738 Changed Int32 to Uint32 and also removed the double memset to '\0' b5657f70e The totalBlocksWriten was placed in the wrong structure and the tests were just by chance passing. Moved to the segment so it is global for the segment and then updated the tests to do a worst possible case. d0b991a5d Merge branch 'master' of https://github.com/mdaus/nitro 72f381baf Merge pull request #124 from mdaus/sync_externals 89e012e7a Merge commit '0cf0612477125a58a3859035edc23067a2ad5e31' into sync_externals 0cf061247 Squashed 'externals/coda-oss/' changes from 02edcc6..c5cf45e 738e51dc0 Merge pull request #123 from mdaus/sync_externals b0797dcf9 Squashed 'externals/coda-oss/' changes from f7c6d83..02edcc6 adc277a15 Merge commit 'b0797dcf9767c5289083ca273e1b3f6f21816fd5' into sync_externals 413bd833e Merge branch 'master' of github.com:mdaus/nitro 245b41e58 Merge pull request #120 from gpotts/master a8d75ee15 Merge branch 'master' of github.com:mdaus/nitro 25a46b2f7 Merge pull request #121 from mdaus/add_test_runner 27d6c961c Merge branch 'master' of github.com:mdaus/nitro a92b350f7 Moved * to the type b54b7ef01 Fixed another type c984218e8 All references pushed to left. Also removed unused code and coments 00490096f Merge branch 'master' into add_test_runner 788fbbff8 Remove externals changes 859a4edbb Removed unused variable 7b8009b81 Merge pull request #122 from mdaus/sync_externals 8a6ffba80 Added a close for the input_io 02a323810 Added c++ implementation also removed the auto from the loop and used the iterator directly 94b3fd92d Making code review fixes. Added constant where needed and made variable types consistant, ... etc 45bcee146 Squashed 'externals/coda-oss/' changes from e570202..f7c6d83 86e1be23e Merge commit '45bcee146d2eadb146c69620b65431c79a99f1b5' into sync_externals 78dcaedc4 Made code review modifications 476fecad1 Initial commit of unit test f3366e080 Add test runner 0e8c6135d Added a check to see if we are on the last block and see if any block is written. If not we need to handle the empty segment where all blocks are blank. ac7b839ce Merge pull request #119 from mdaus/move_version_up e34890282 Move version up a level to fix how it works with other libraries 8bbd8a370 Merge pull request #117 from mdaus/msvc_version_upper_bound 0d1ec3e6b Add upper bound for compiler bug version check e48d85a80 Merge pull request #116 from mdaus/installer 84027eb85 Update installer script bf9fc4d88 Merge pull request #115 from mdaus/updateVersionScript b9a606060 Update updateVersion script 6d837fcee Merge pull request #114 from mdaus/updateVersion b17c1d51a update nitf/shared/wscript 3d0139a4b Update version to 2.8 d564f0198 Merge pull request #111 from mdaus/msvc_better_workaround c4f0514aa Disable buggy optimizations 6f6e3dea0 Revert "Work around MSVC bug" 9731f1c57 Revert "Cleanup" 5d965f323 Merge pull request #110 from mdaus/j2k_static_link 414368458 Enabling J2K compressor/decompressor plugins to be linked statically 09001cb51 Adding macros for decompression 48eb848f8 Merge pull request #109 from mdaus/skip_empty_buffer f02cf8056 No reason to add an empty buffer 3b9abd24e Merge pull request #108 from mdaus/infer_max_num_rows_per_segment aad7aa285 Setting maxRowsPerSegment is problematic - should be inferring it 61ebb74a5 Squashed 'externals/coda-oss/' changes from a78b22c..e570202 943be4b68 Merge commit '61ebb74a5ff3a591dccd0ac6d002bd628509e84c' dbb158aa6 Merge pull request #106 from mdaus/fix_get_size_impl eb4b52109 Reverting change to length calculation... the old way was correct. There was a bug in IOStreamReader::getSizeImpl() d21a837c5 Fixed bug in how IOStreamReader reports its size e03d21f1a Merge pull request #105 from mdaus/byte_provider_update 9f7dbbaa4 Merge pull request #104 from mdaus/add_blocking_overloading ddc98729e A single buffer can be added edee5c2d7 Removing unused function c194e5307 Adding static block() method that performs a single block operation eb4390829 Merge pull request #103 from mdaus/fix_openjpeg_reader caaa58f4b Fixed bug in J2K reader that was subtracting off an offset resulting in OpenJPEG thinking the last tile was incomplete d14c1a1a0 Merge pull request #102 from mdaus/msvc_bug 062968843 Cleanup 5db2e51fd Work around MSVC bug 047aea308 Merge pull request #101 from mdaus/bugfix/multiple-des-buffers-in-bytestream eb0497031 ByteProvider interface already supports writing multiple DES buffers. Unfortunately, the subheader length is not correct because the ByteStream it uses to tally buffer size continues to increment. ed27b4652 Merge pull request #100 from mdaus/fieldErrorMessage f1d41f065 Make message more useful for common error scenario 93e9d1a57 Merge pull request #97 from mdaus/larger_type 5a85881bb Include proper headers 312e676f8 Better overflow handling 7d1044511 Python should be able to read NITF with size_t bytes c7fb89f58 Merge pull request #95 from mdaus/add_helper_method 2bbbbcb43 Adding convenience method 55aa2595a Merge pull request #94 from mdaus/sync_externals 945288d7a Squashed 'externals/coda-oss/' changes from 0630826..a78b22c cc658b9e6 Merge commit '945288d7ade1b4b8666efaa3056e0bb1c18e89e4' into sync_externals 365ccc712 Merge pull request #93 from mdaus/sync_externals 124a3c4d8 Squashed 'externals/coda-oss/' changes from 8499ef8..0630826 e52808265 Merge commit '124a3c4d82e5950f37837802633ae26304319345' into sync_externals 39ff4cf55 Merge pull request #92 from mdaus/sync_externals a4c22ea64 Squashed 'externals/coda-oss/' changes from 026c665..8499ef8 910785d38 Merge commit 'a4c22ea646a2234bd26c8a97b5f3b8ff4326aba0' into sync_externals 8d40e3f10 Merge pull request #91 from mdaus/nitf-segment-block-size 4cc661019 Adding comments 73305edc7 Make nitf image segments force to a block size number of rows 3b4e96d51 Merge pull request #90 from mdaus/compressedDEScheck f83748478 Correct check for DES addition 23fe60baf Merge pull request #88 from mdaus/byte_provider_bugs 830b39e73 Add method for finding segment from block 069672706 Remove commented code 5b1cb1849 Add const 68fee31cb Add pad rows back in 345fe2b75 Merge pull request #89 from mdaus/fixWscript 2923a4299 Fix bug in wscript 0314391e7 Fix bugs in ByteProvider and j2k wscript 351dfdec4 Merge pull request #87 from mdaus/fix_blocker_check d778aa255 Add check for no rows 6b1d67d30 Merge pull request #85 from mdaus/addCompressedByteProvider 11be6c242 Update comments and metadata f22f89b33 Fix comments and test ac66cbac8 Add writing test sample 4f9f9d7e6 Copy over unittests c7620ca58 Add compressedByteProvider 5d0f61da1 Merge pull request #84 from mdaus/sync_externals 21cb254e4 Merge CODA-OSS, get J2K to build, update SWIG 6bd6adee7 Squashed 'externals/coda-oss/' changes from 9063b5f..026c665 85eb614d8 Merge commit '6bd6adee79a3ba9f847e5f41b27a0061df1273db' into sync_externals 0cefba6d7 Merge pull request #82 from mdaus/sync_externals ed35c27b5 Squashed 'externals/coda-oss/' changes from 43cd38f..9063b5f 52b9b9c9b Merge commit 'ed35c27b56a86965cb71fd65779d11102b197937' into sync_externals 5f2ef1a2b Merge pull request #81 from mdaus/sync_externals 37ffb4e86 Merge commit 'b3b00587ddd09fc6a9749b2029661e46e9f4f0de' into sync_externals b3b00587d Squashed 'externals/coda-oss/' changes from 3ac2993..43cd38f d6f0d0c33 Merge pull request #80 from mdaus/sync_externals ba346af35 Squashed 'externals/coda-oss/' changes from 3a5d8bb..3ac2993 cfdfac1ee Merge commit 'ba346af3524663e15ee93fa1437aa5570747ced3' into sync_externals 43bcaad3d Merge pull request #79 from mdaus/added-include-guard d6f16d006 Added include guard 148851bd1 Merge pull request #78 from mdaus/merge-2018-03-21 f8cc2f231 Squashed 'externals/coda-oss/' changes from ced15b8..3a5d8bb 7f44a614e Merge commit 'f8cc2f231f7e647bceeb04513b2b3dde294ad5ca' b7e2273b5 Merge pull request #77 from mdaus/memoryIssues 1a8a3f673 Fix comments 01281e8b3 Fix some memory errors that happen during cleanup bb4d71ff7 Merge pull request #76 from mdaus/generalize_byte_provider 59ad6167d Adding generalized ByteProvider bf6124306 Merge pull request #75 from mdaus/checkCompressionHandler e138c3bfe Fix comments 7f70a6d7f Add check for compression/decompression handlers 8413ff689 Merge pull request #74 from mdaus/byte_provider c51ab40c6 Moving functionality from SIX into NITRO to support getting raw bytes easily 827cb146b Merge pull request #73 from mdaus/addCompressionHandler 5de11795b Fix error message 568eec942 Doxygen 51a40144f Add handler for static compression plugin 8f8268a30 Merge pull request #69 from mdaus/add_image_blocker 411f697f4 Removing todo a1c6e28ed Adding ImageBlocker 0180a0b90 Merge pull request #68 from mdaus/jpegDecompressorFix 823f2b3cc modules/c/jpeg/source/LibjpegDecompress.c 7dcc7d7f6 Properly initialize JPEG decompression control 6075d27a8 Merge commit 'e09d081bb9b01ffb38d607bcd1895ccf66cb47b1' e09d081bb Squashed 'externals/coda-oss/' changes from ead59a7..ced15b8 46608ad54 Merge commit 'e190ac7911d7cf799d62da15cb8aeb560de9de0c' e190ac791 Squashed 'externals/coda-oss/' changes from c323a80..ead59a7 534641317 Merge commit 'f9a2697551fefedd798700a644d296ebcbdb4eef' f9a269755 Squashed 'externals/coda-oss/' changes from cab618a..c323a80 5f5a8a199 Merge pull request #63 from mdaus/sync_1128 d670637fb Updating with InputStream API changes and fixing warnings c0fe5b683 Squashed 'externals/coda-oss/' changes from a4c9552..cab618a 3d8b3fabd Merge commit 'c0fe5b683f341c60f153881ee4c0d0792ceec069' into sync_1128 05df4678c Merge pull request #61 from s-martin/master 3307d790e fixed missing toString 09a1be208 Correctly declare variables 9e212fead Merge pull request #60 from mdaus/nrt-datetime-declarations b02f2adcc place variable declarations at top of scope 590776bae Merge pull request #58 from mdaus/doxygenFix d687d88c3 Fix params in BandSource Doxygen c398336c1 Merge pull request #57 from mdaus/nrtUtilsBugs fe5e8dafc Test more edges c9cbb7f6d Fix bugs in utilities for manipulating coordinates d833ee31b Merge pull request #56 from mdaus/nrtUtilsMessage 7c8653823 Add more detail to exception message dc487c4b0 Fix error message for invalid direction 85aa0655e Removing old copying files since we have a LICENSE file now 8a6fc23e5 Create LICENSE cf7a3492c Merge pull request #53 from mdaus/datetime-dayofyear-parsing 0b631a998 simplify setMonthInfoFromDayOfYear logic 3879a4ec1 use NRT_TRUE and NRT_FALSE instead of 0 and 1 71e6e384f missing word dbcab7245 clean up dfea090ad clean up 253039ccb Use NRT_BOOL instead of int c0298e17a remove tm based offsets in setMonthInfoFromDayOfYear 1c31e6ac5 clean up 6e4ce06c6 add ability to parse day of year and infer month and day of month to DateTime af0dc0425 Merge pull request #52 from mdaus/segmentation_logic ad9c3ff60 Moving image segment logic from SIX into NITRO 228db3389 Merge pull request #51 from mdaus/fix_offset f7e97e50a Fixed bug in bufferSize calculation due to misplacing a parenthesis 4a7a8bfe6 Merge pull request #50 from mdaus/fix_buffered_reader b10751992 Using the sys::File enum values c3ce72967 Fixed a bug in bookkeeping on buffer size - need to keep track of both a max and a current value. Also optimized seekImpl() to not do another read if the spot we want to seek to is already in memory. 1293652c1 Merge pull request #49 from mdaus/updateSwig b5b8c1df7 Update SWIG-generated code to 3.0.12 9a47ed2e3 Merge pull request #48 from mdaus/const_iterator_fix fc5476255 Make const_reverse_iterator work on Solaris 8eb8bcea5 Merge pull request #47 from mdaus/stripUtility f215229c5 Fix typo; better type 2a30b3aae Update to use new addWriteHandlers() method 443a0d286 cout -> cerr where appropriate 40102c821 Add program to strip out segments that aren't displayed 6d1e1b3e1 Merge pull request #46 from mdaus/showNitfFormatting 68e1d4fb8 Insert a space between the number of bytes and the word 'bytes' 36172d3bb Merge pull request #45 from mdaus/geoUtilsFix 26996f6c6 Update doxygen 3ba90d8e4 Style fixes 89b1c81d5 Check for failed malloc e2c521335 More documentation for parseDecimalString e956109f3 Add const to char* where applicable 860916a22 Fix documentation and logic for decimalToGeographic 4daa833e8 Update documentation and change char* to const char* b69de1646 Change DMS convention to make first nonzero value be sign 863ae2acc Fix unused parameters 25f359508 Simply handling W/S DMS; fix bug with 0 degrees a5150d1eb Merge pull request #43 from mdaus/add_output_stream_adapter 5fb719303 Fixing line endings 8705d673b Adding convenience method to set the complexity level in the Record fa01d24e7 Fixed some typos 502e65ca4 Adding OutputStream adapter class b9ac25fa5 Merge pull request #41 from bradh/ccinfa 458a0d671 Initial commit for CCINFA TRE. 2eea35c64 Merge pull request #38 from mdaus/template_field_operator 8631fa1b8 Adding size_t cast tests too e53072f34 Explicit specializations need to be at namespace scope fb72c8957 Rather than having overloadings for the cast operator, implement this as a templated type. This should let picky compilers perform some additional casts automatically for us now too (like uint64_t vs. size_t... for some compilers, this is the same type, but for others it's not) ee16abbba Added conversions for 1 byte integers c9dfbada5 Merge pull request #37 from mdaus/windows_gcc afeba21be Merge branch 'master' into windows_gcc 73f5b0b89 Squashed 'externals/coda-oss/' changes from 2645b4f..a4c9552 eb245cf73 Merge commit '73f5b0b894776e45900d6f83af0fbcd45e69c329' 021e1e0a9 The keyword 'interface' is reserved on Windows... for some reason VS doesn't mind but gcc on Windows does c8eef0f86 Need the GNU NRT_INT64 macro when we're building with gcc on Windows 3fc1b27eb Merge commit '53c3e977d5476ac9cb10f5bd3d0c7e29f7c29ad6' into windows_gcc 53c3e977d Squashed 'externals/coda-oss/' changes from 2645b4f..a4c9552 c73ffd6ff Merge pull request #35 from mdaus/fix_uint64_offset_bug 83ab81888 Added const to fix a compiler warning bdf0dc1b6 Fixed subtle bug in handling of 64-bit offsets... previously, if we tried to read in with an initila offset > 4 GB into an image segment, this did not work properly because it was treated as a 32-bit number in one of the calculations. Also added a few compiler warnings. 77fbcc1f1 Squashed 'externals/coda-oss/' changes from ba5cb1d..2645b4f 60c8b6758 Merge commit '77fbcc1f15a1f039e8d9b5b668d0e93816524c0b' 82884746d Merge pull request #34 from mdaus/inlineFix 47e6932b6 Make switch apply only to inline 0d9f454fe Add clarifying comment c6fd10bbd Use __inline instead of inline on Windows to deal with how VS deals with C code 439c03423 Don't need PCRE for NITRO e6f977946 Merge commit 'abbf6bb6a623d4ba5f5145c45e5166ab5953fd52' abbf6bb6a Squashed 'externals/coda-oss/' changes from 821312e..ba5cb1d 5413fb99c Merge pull request #28 from mdaus/typoSwap e71613a51 Inline swap function e730c6e40 Merge pull request #31 from mdaus/solarisFix 1fa194127 Fix line endings 9742f0e5d Merge pull request #30 from mdaus/investigateCompression 96839ad66 Merge in master ee5ded5e0 Style fixes 41194e6b5 Handle 8-byte case; add helper function 85901def5 Merge pull request #29 from mdaus/whitespace e4e4cf8e4 Do not do anything with blocking when compressing images with blocking mode P 815e28d57 Add byteSwap method 26dd44521 Revert change from different issue. 0b9ba0705 Remove more trailing whitespace 9964db2c4 Mass removal of trailing whitespace dae3a0a43 Unpack padCodeLength in correct order cd918392a Revert "Unpack padCodeLength in correct order" fb949d433 Unpack padCodeLength in correct order fce5fe447 Fix typos and attempt test 541d50a3b Merge pull request #27 from mdaus/fixBigEndianByteSwap c6aed55c9 Remove bad byte swap and fix comment typos 2cbf08790 Merge pull request #26 from mdaus/io-stream-reader 0b388861e Added IOStreamReader to imports ff553601a Added IO stream reader bee4d4cb1 Merge pull request #25 from mdaus/addNumpyCheck f898f7eb7 Remove unused import cd9363953 Fix how wscript looks for numpy b1821d4b5 Disable Python bindings if numpy is not loaded fe5317e5e Merge pull request #24 from mdaus/adding-banners 3191a5967 Added banners 84a6deab3 Merge pull request #23 from tclarke/master 73b2ff159 Changed C cast to C++ static_cast 00876524b Fix ambiguous cast on clang. 143b5a7b1 Merge pull request #21 from mdaus/windowsFix 932587659 Add cast bf5dd53c3 Fix placement of preprocessor statements f415279a4 Fix types for Windows HANDLE 1069ab16a Fix space eae3d8c3a Remove extra file 7a394738a Fix tests on Windows b55ce7d46 More playing with typemaps 9c8cf4390 Try an in typemap f671dbbc7 Try an out typemap 957852668 Add typemap 00e010173 More wscript tweaking a6cbbe95e Add numpyutiles to non-swig wscript poriton 7af77d569 Try generated c files 2acdb5660 Merge pull request #19 from mdaus/dualCompatability 579137b62 Remove commented code 6e1fa7b13 Achieve basic Python3 compatabiliy 8920a0b3b Merge pull request #18 from mdaus/support_seeking_write 5540183e6 Exposing C functions for writing out pieces of a NITF in the C++ layer 2a7ce275c Exposing some of the previously private functions for a Writer in the header so someone could write out parts of a NITF directly themselves f3e5260c5 Make python bindings compile with C++ a7e67867d Merge branch 'master' into dualCompatability to get new numpyutils d63e4b2db Make importing numpyutils work 494d5c0f9 Merge pull request #17 from mdaus/fix_swig_bindings 9a93bab32 Updating Swig bindings with Swig 3.x 12b2656cd Merge pull request #16 from tclarke/python_fixes 7466daabc Add raw field access and setField to python TRE interface 386914ba0 Merge pull request #14 from mdaus/remove_includes cadb29006 Need to remove adding include directory to TRE targets... otherwise waf msvs gets confused (the directories that build.py automatically adds on don't exist 86838355b Merge pull request #13 from mdaus/support_static_tres 1634d7a06 Added treHandlerExists() 517c14c4a Added nitf_PluginRegistry_TREHandlerExists() function to test if a TRE handler exists. Various cleanup on debug logging support. 9ddcd493b Minor style stuff - catch exception by const ref, catch ..., put macro in unnamed namespace ae376973d Building test_static_plugin.cpp when static TRE support is turned on 697def4b8 Resurrecting support for static TRE linkage. Now adding a configure option for this so it doesn't happen by default. Also, each TRE is compiled into its own library with its own target rather than there being one library that has all of them ff008dd2b Sending options() and configure() down a level. Removing now unneeded convenience targets for the tests. test_static_plugin.c doesn't actually exist so removing from TEST_FILTER 7fadf94f0 Updating maintainer email address eee8c88c2 Commenting out variable name to avoid Windows warnings about unused variable 00838ee07 Updating static TRE macro based on TRE API change e30e59b4a Merge commit 'c2cfdfa1e051f75857d7d9014f99d2e7cd098116' c2cfdfa1e Squashed 'externals/coda-oss/' changes from da6141c..821312e 225ead1e1 Merge commit 'eca06504e370f2542b63d9b187cec7d97d261423' eca06504e Squashed 'externals/coda-oss/' changes from 070dda5..da6141c 50750b906 Merge pull request #12 from mdaus/segmentErrorHandling cffabde62 Catch segfault if SegmentWriter does not have a SegmentSource attached bdd5f1546 Merge pull request #10 from mdaus/replace_company_name e3a487d8d Replacing GD copyright with MDA b2b133315 Update tests to Python3 d4f03a24f Update print and raise statements in __init__.py 238b84317 Squashed 'externals/coda-oss/' changes from 0f8115c..070dda5 779c1e87b Merge commit '238b8431779b4e0aa256e4378e05cacc42064c07' 56acaa4aa Merge commit '3bacfb5de4860f9fa5655a5eeac3f39ece31b0b3' 3bacfb5de Squashed 'externals/coda-oss/' changes from b6d55dd..0f8115c 410f053f6 Merge pull request #8 from mdaus/copyright bb6903876 Remove debugging line df6dbbaa1 Update copyright header to MDA info 1fd475fd3 Merge pull request #7 from mdaus/nitropyFixes 57a090dd8 Remove useless, cryptic error message 2b55bde0d Fix IOHandle.write() in nitropy. Write more tests c7c4c8e87 Fix constructor and destructor of MemorySegmentSource 392e7994a Remove debug print statement f5c74e910 Write to file with numpy array instead of string 2d862acbe Fix bandcounting in nitro.i 4a9b58844 Fix discrepancy in band count 104e75213 Prevent segfault when nbpp changes 712577697 Merge pull request #6 from mdaus/bandsource-variable-order 4d85ad137 Moved the variable declarations to the top of functions 022f0bac0 Merge pull request #5 from mdaus/fix_j2k_header_install 8266f6160 j2k_config.h was getting installed via copyfile rather than the clean way to do it by making it its own target... this meant it just straight up tried to copy itself to the installation directory, even during the build step. Not cool. 9448119fc Squashed 'externals/coda-oss/' changes from 446809f..b6d55dd f9d46f3f7 Merge commit '9448119fc0e79948966731e6ccc39459ad2aa666' c6a7f5a13 Merge pull request #4 from mdaus/warnings 86025e984 Fixed whitespace 826f5153e Fix indentation. 33e47d9a5 Fix compilation errors d1b40551b BandSource.c: Fix indentation, variable names 5d60469d9 Remove formal parameter warnings from BandSource.c a8fee3662 Squashed 'externals/coda-oss/' changes from 93b6be6..446809f 83ad28c87 Merge commit 'a8fee36621cdf8a9b435f49961951957ead41e4b' 3f9dc2a14 Squashed 'externals/coda-oss/' changes from 6577104..93b6be6 a5225294a Merge commit '3f9dc2a14529a1d0bb3ba73158d01bddbc3bec29' cb7da3b61 Squashed 'externals/coda-oss/' changes from 47c416f..6577104 357e9ed84 Merge commit 'cb7da3b61a0dd00e87c87abe4cd35634fb9b4b2c' 606e5f086 Correcting sprinf()-style formatting for unsigned integer in error messages... was leading to garbage being printed previously eddf8b596 Merge commit '12be28aa5b0fef668e189bc1ae3b23ecc3393a88' 12be28aa5 Squashed 'externals/coda-oss/' changes from fb34fe8..47c416f d79e28f43 Merge commit '39d16bac68a64e9b2fafce11fca86d4e1a034355' 39d16bac6 Squashed 'externals/coda-oss/' changes from 66a39a7..fb34fe8 1cd19826c Merge commit '7f334d286e91d82043b68e5fa95bcf6040fbad53' 7f334d286 Squashed 'externals/coda-oss/' changes from 1335087..66a39a7 f1f1ecc5a Merge commit '0548865e39c60e6faed01be7c9992ca4580f895c' 0548865e3 Squashed 'externals/coda-oss/' changes from 00439a0..1335087 0e33f967e Merge pull request #3 from mdaus/warningFix 34fb875f6 Added a space to a file to prevent a warning when compiled with c++ 11 b45222832 Merge commit '0638f7b7e498502a10ac408496de8137fe9e16bf' 0638f7b7e Squashed 'externals/coda-oss/' changes from a12bbff..00439a0 105bbff87 Using launch_dir() to just add in all the targets rather than needing to list them all e5e8c357a Generating Python bindings with latest Swig d2f6ab84e Squashed 'externals/coda-oss/' changes from be445dd..a12bbff 034e03adf Merge commit 'd2f6ab84e350377eec7eef2076c952eabb61f6d8' 9817e3aeb Merge pull request #2 from porglezomp/master 072e4dd0b Add gitignore 330834cd4 Squashed 'externals/coda-oss/' changes from d372600..be445dd 1f5e7d5be Merge commit '330834cd411203237c5ae81e863efa0c81ec08c8' 92a7f3ce1 Adding some more info about dealing with conflicts 52cbdfa97 Merge commit 'b99e2d58eb87d6e890caa3060c0439ee8fc42dfa' b99e2d58e Squashed 'externals/coda-oss/' changes from 24ac763..d372600 906a355e7 Recurse down whichever directories are present 33d61b0c5 Temporarily renaming directory so waf list works. Need to fix this to actually build this target anyway. d73131e7c Should have a HAVE_MATLAB check around everything in order for waf list to work properly... otherwise it'll fail trying to find the Matlab targets when we don't have Matlab 9a3283483 Updating wscripts to add various convenience targets for the tests. Then updating top-level wscript to only build the targets that are needed 38b6103c1 Updating script with how to remove unwanted externals. Getting rid of old unneeded Makefiles ecfdcb26a Removing unneeded externals via 'git rm -r' 543683bec Reorganizing directory structure to make it easier to use in other repos be02d6b6b Syncing up with coda-oss reorganization f4f5356e7 Squashed 'externals/coda-oss/' changes from 48c8888..24ac763 66454ce46 Merge commit 'f4f5356e7085353eb85ef648f7b67cc4a139b7d7' 6c5dabadb Fixed coda-oss location d083ece96 Squashed 'externals/coda-oss/' changes from 67630c6..48c8888 b21d8af45 Merge commit 'd083ece96e66c9ebc4d652f7e95124eb42418c65' 040e969da Added script for syncing externals 46a9abdef Fixing wscripts with new externals structure 2153a485b Using subtree merge to pull in CODA-OSS dd6a26c96 Squashed 'externals/coda-oss/' content from commit 67630c6 bf8076897 Merge commit 'dd6a26c969dd6580cb0200bfa7697d39250a6e8e' as 'externals/coda-oss' 39d5856da Qt is lame and uses a foreach macro which conflicts with the HashTable::foreach() method, so renaming to forEach() to sidestep it 08eda08bb Fixed a bug introduced when NUMPRJ was updated to NUM_PRJ... the NITF_LOOP needs to also use NUM_PRJ to take this field into account. 404ef684c Moved some functionality to build.py. #447 8d5c555cc Cleaned up warnings in BufferedReader. 6cc2386a2 Added a BufferedReader similar to BufferedWriter. 08c52905a Adding comments for various getter/setter methods. Adding constructor that allows direct construction from specified year, month, and day. a2fe6cceb Added comments describing date format 05d96d0f7 Updating copyright banner to MDA 668a19a00 Previously Java binding for nitf_Extensions_getTREsByName() crashed when the TRE was not found as it didn't check if the returned list was NULL. Added in this check and marked the method as potentially throwing an exception. 3484657bc Removing unused variables 97d234594 Fixed a shortcoming in how NRT_MAX_PATH was defined that could result in mismatches and seg faults if someone included sys/param.h before nrt/Types.h due to MAXPATHLEN being defined by sys/param.h. #405. 8abe1f8ac Removed define OPJ_STATIC from j2k wscript to stop redefinition…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug itself was in NITRO - this PR is just to merge it in - but this resolves a bug that occurred when you requested a start row into a SICD/SIDD that resulted in a byte offset into an image segment that was > 4 GB (we were using a uint32 rather than a uint64 at one spot in the calculation).
FYI @JonathanMeans