All calls to getExtent should be generic bounding volumes #851
Labels
Comments
smithtb
pushed a commit
to smithtb/opensphere
that referenced
this issue
Oct 7, 2020
…phere:upscanMerge to master * commit '851fbf4086b98b0139abebf0b3ad358f70d11766': ci: remove release debug check [skip ci] docs(wmts): Trivial cleanup on WMTS apidoc. fix(annotations): Fix UI issues with indentation and proper disabling fix(annotations): Limit scope of "show background" option feat(annotations): Add label-like abilities to annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All places which use
getExtent()(from layers, geometries; aggregated or single, etc.) should really be using a templated bounding volume type. This would be extents in the 2D OpenLayers view and 3D BoundingSpheres in the 3D Cesium View.Currently, any use of
getExtent()related to moving/fitting the view for 3D can be incorrect if those features contain altitude (the camera can zoom past the features). We have somewhat addressed this in the feature-specific flyTo (os.feature.flyTo) used by KML, selected features context menu in the "Show Features" list, and selected features "Go To" in the Timeline. However, this needs to be done everywhere, especially for the layer menu.The text was updated successfully, but these errors were encountered: