Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save State prompt on close #602

Open
wisestmumbler opened this issue Jun 7, 2019 · 1 comment
Open

Save State prompt on close #602

wisestmumbler opened this issue Jun 7, 2019 · 1 comment
Labels
enhancement

Comments

@wisestmumbler
Copy link
Collaborator

If there is a save state active and changes have been made (e.g. layers added, filters made, etc.) a prompt should ask you if you want to save over your state with the new application state.
@wisestmumbler wisestmumbler changed the title Save State warning on close Save State prompt on close Jun 7, 2019
@wisestmumbler
Copy link
Collaborator Author

wisestmumbler commented Jun 10, 2019 •
edited
Loading

There are a lot of weird edge cases involved here, so this might not work out.

After talking a little with @schmidtk I think the way that this will work is to:

  1. Recognize that there is only one state loaded
  2. Recognize that something on that state has changed (e.g. a filter added to a layer loaded by the state)
  3. On close, prompt the user to cancel the closing (or continue) and direct them to save their state (as opposed to trying to save it for them)

jsalankey added a commit to jsalankey/opensphere that referenced this issue Jun 12, 2019
@jsalankey
Merge pull request ngageoint#602 in WV/opensphere from ~SALANKEYJ/ope…
d668f93 
…nsphere:THIN-12625 to master

* commit '479863756bbc89f72e71d9ac9a02a0dd2e900de4':
  fix(kml): fixes parsing of float refreshInterval values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wisestmumbler