72 #74
Closed
72 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjudeng
reviewed
Jun 11, 2018
| @@ -167,8 +167,14 @@ private ElasticRequest prepareSearchRequest(Query query, boolean scroll) throws | |||
| } | |||
|
|
|||
| if (dataStore.isSourceFilteringEnabled()) { | |||
| // add source includes | |||
| setSourceIncludes(searchRequest); | |||
| if (query.getProperties() != Query.ALL_PROPERTIES) { | |||
There was a problem hiding this comment.
Can you add a test to hit this case if there's not one already?
…nning the IT on server. Therefore switch to just checking to ensure the count is greater then 2
sjudeng
approved these changes
Jun 11, 2018
|
Submitted a squashed version as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#72 Limited the source filtering to the properties specified by the query.