Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NgbAccordion - destroyOnHide - doesn't seem to work correctly #1915

Closed
sourcedump opened this issue Oct 24, 2017 · 6 comments
Closed

NgbAccordion - destroyOnHide - doesn't seem to work correctly #1915

sourcedump opened this issue Oct 24, 2017 · 6 comments

Comments

@sourcedump
Copy link

Hello everyone,
if I set the 'destroyOnHide' option to the boolean 'false', the accordion don't close the panels anymore.
If you use one of your link in Plunker (eg: this) and put [destroyOnHide]="false" on the first line of the 'src/accordion-toggle.html' file you can see the effect.

Here the versions of the libraries that I'm using:

  • Angular: 4.4.5
  • ng-bootstrap: v1.0.0-beta.5
  • Bootstrap: v4.0.0-beta

Thank you!

@maxokorokov
Copy link
Member

maxokorokov commented Oct 24, 2017

Looks like it doesn't work to me too. Here is the link the plunkr that simply adds [destroyOnHide]="false"
http://plnkr.co/edit/IFv7b0VIn2zcqoJKclZX?p=preview

@skrzepij
Copy link

skrzepij commented Nov 6, 2017

Same issue here.
Any ideas how to workaround this bug?

@atarix83
Copy link

atarix83 commented Nov 6, 2017

I have the same issue too.
There is a fix?

@DenverDrew
Copy link

I am also having this same issue.
Any ETA on a fix?

@maxokorokov
Copy link
Member

You could take a look at #1940

@sourcedump
Copy link
Author

I've tried the solution in #1940 and it works for me

@maxokorokov maxokorokov added this to the 1.0.0-beta.7 milestone Nov 17, 2017
maxokorokov pushed a commit to bbalvanera-zz/ng-bootstrap that referenced this issue Nov 21, 2017
Add .collapse class to panel. When destoyOnHide is set to `false`, the panel remains visible due to a missing bootstrap class

Fixes ng-bootstrap#1915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants