Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tough-cookie and tap #237

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 4, 2023

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Removes tough-cookie. It's no longer used after updating ancestor dependency tap. These dependencies need to be updated together.

Removes tough-cookie

Updates tap from 15.0.5 to 18.4.2

Release notes

Sourced from tap's releases.

[email protected]

No release notes provided.

[email protected]

What's Changed

Note: The formatting of Symbol objects and enumerable Symbol properties has changed in snapshots and object diffs.

You may need to run tap --snapshot after updating to this release, and/or update some tests that were relying on symbol property keys being ignored.

  • Include Symbol keys in formatting/comparison.
  • Print symbols in formatted objects as Symbol.for(...) if appropriate.
  • Print known symbols from the Symbol constructor as Symbol.<key>, eg Symbol.iterator instead of Symbol(Symbol.iterator).
  • Add reporter-file config option tapjs/tapjs#931

Full Changelog: https://github.com/tapjs/tapjs/compare/[email protected]@18.4.0

[email protected]

Bug-fix, actually turning off type checking by default, as intended.

[email protected]

Full Changelog: https://github.com/tapjs/tapjs/commits/[email protected]

[email protected]

What's Changed

... (truncated)

Commits
  • 5c114fc update versions
  • 5811079 fix timing issue breaking node --test serialization
  • 69c31a8 update versions
  • 2dfff65 @​tapjs/processinfo@​3.1.4
  • c433477 tcompare: include known non-enumerable Error properties
  • d089e7e tcompare: print symbols properly in js formatting
  • 390b9f9 put the logo in the header
  • 414d146 update versions
  • 63cc9c4 snapshots updated by Symbol formatting change
  • 995e464 changelog 18.4
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 4, 2023
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/tough-cookie-and-tap--removed branch from 33a4ab9 to 5f60e51 Compare October 17, 2023 17:51
@nfriedly
Copy link
Owner

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/tough-cookie-and-tap--removed branch from 5f60e51 to 3315064 Compare October 17, 2023 19:06
@nfriedly
Copy link
Owner

@dependabot rebase

Removes [tough-cookie](https://github.com/salesforce/tough-cookie). It's no longer used after updating ancestor dependency [tap](https://github.com/tapjs/tapjs). These dependencies need to be updated together.


Removes `tough-cookie`

Updates `tap` from 15.0.5 to 18.4.2
- [Release notes](https://github.com/tapjs/tapjs/releases)
- [Commits](https://github.com/tapjs/tapjs/compare/[email protected])

---
updated-dependencies:
- dependency-name: tough-cookie
  dependency-type: indirect
- dependency-name: tap
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/tough-cookie-and-tap--removed branch from 3315064 to 5151821 Compare October 17, 2023 19:10
@nfriedly
Copy link
Owner

nfriedly commented Nov 8, 2023

@dependabot rebase

1 similar comment
@nfriedly
Copy link
Owner

nfriedly commented Nov 8, 2023

@dependabot rebase

@nfriedly nfriedly closed this Nov 8, 2023
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 8, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 8, 2023

Looks like this PR is closed. If you re-open it, I'll rebase it, as long as no-one else has edited it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/tough-cookie-and-tap--removed branch November 8, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant