Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanner token parsing refactor #353

Merged
merged 7 commits into from
Oct 11, 2021
Merged

Scanner token parsing refactor #353

merged 7 commits into from
Oct 11, 2021

Conversation

nfrasser
Copy link
Owner

The DOMAIN token (among others) has been removed in favour of WORD, UWORD and other tokens. SCHEME (formerly PROTOCOL) tokens now come in several flavours.

Includes additional facilities for token groups, which will be useful for future plugins down the line.

Removes some invalid mentions which probably never should have been marked as mentions

Fixes #171
Fixes #245
Fixes #351

The DOMAIN token (among others) has been removed in favour of WORD, UWORD and other tokens. SCHEME (formerly PROTOCOL) tokens now come in several flavours. Includes additional facilities for token groups, which will be useful for future plugins down the line

Also fixes file URL behaviour
Also improves hashtag and mention plugin accuracy
@nfrasser nfrasser self-assigned this Oct 11, 2021
@coveralls
Copy link

coveralls commented Oct 11, 2021

Pull Request Test Coverage Report for Build 1327368545

  • 292 of 297 (98.32%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+92.7%) to 92.732%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/linkifyjs/src/linkify.js 2 7 28.57%
Totals Coverage Status
Change from base Build 1246226134: 92.7%
Covered Lines: 844
Relevant Lines: 878

💛 - Coveralls

@nfrasser nfrasser changed the base branch from main to v4.0 October 11, 2021 14:24
@nfrasser nfrasser merged commit e1237f7 into v4.0 Oct 11, 2021
@nfrasser nfrasser deleted the scanner-token-refactor branch October 11, 2021 15:10
@nfrasser nfrasser restored the scanner-token-refactor branch October 11, 2021 15:10
@nfrasser nfrasser deleted the scanner-token-refactor branch October 11, 2021 15:10
@coveralls
Copy link

coveralls commented Jul 11, 2024

Pull Request Test Coverage Report for Build 1327368545

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 292 of 297 (98.32%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 92.812%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/linkifyjs/src/linkify.js 2 7 28.57%
Totals Coverage Status
Change from base Build 1246226134: -0.2%
Covered Lines: 844
Relevant Lines: 878

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants