Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My first-ever PR: adding sack yards and total fumbles (to go with the existing fumbles lost column) #239

Merged
merged 6 commits into from
Apr 15, 2021
Merged

My first-ever PR: adding sack yards and total fumbles (to go with the existing fumbles lost column) #239

merged 6 commits into from
Apr 15, 2021

Conversation

TheMathNinja
Copy link
Contributor

Please tell me this works.

@tanho63 tanho63 changed the title My first-ever PR My first-ever PR: adding sack yards and total fumbles (to go with the existing fumbles lost column) Apr 14, 2021
@guga31bb guga31bb linked an issue Apr 14, 2021 that may be closed by this pull request
Fumbles lost in calculate player stats: aborted snap issue #238
Closed
@mrcaseb
Copy link
Member

mrcaseb commented Apr 15, 2021

Ran some checks and think this PR is fine. Overall summary:

This PR

  • adds the variables sack_yards, sack_fumbles, rushing_fumbles and receiving_fumbles to calculate_player_stats() and
  • fixes a *_fumbles_lost bug for aborted snaps by comparing the fumnble player id with passer, rusher or receiver player id

This also adds some of the requested variables in #235

@mrcaseb mrcaseb merged commit 741edb2 into nflverse:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fumbles lost in calculate player stats: aborted snap issue
2 participants
@TheMathNinja @mrcaseb