-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with React 16.9 #472
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| { | ||
| "name": "react-helmet", | ||
| "description": "A document head manager for React", | ||
| "version": "5.2.1", | ||
| "version": "5.2.2", | ||
| "main": "./lib/Helmet.js", | ||
| "author": "NFL <[email protected]>", | ||
| "contributors": [ | ||
|
|
@@ -33,7 +33,7 @@ | |
| "object-assign": "^4.1.1", | ||
| "prop-types": "^15.5.4", | ||
| "react-fast-compare": "^2.0.2", | ||
| "react-side-effect": "^1.1.0" | ||
| "react-side-effect": "^2.1.0" | ||
| }, | ||
| "devDependencies": { | ||
| "babel-cli": "^6.24.0", | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can't be a patch upgrade, a new version of
react-side-effectuses react >= 16.9#501 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay understood, so need to create different pull react for future minor version or you already added into development plan? Asking because I am not seeing any label on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just noticed that upgrade of react-side-effect breaks backward compatibility (I’m not a maintainer of this repo)
Personally I would like to help to resolve react depreciations, but it looks like
react-helmet-asyncappeared for a reason with the same intentionsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, and @wheeler mentioned so already few months ago, however since this package is no longer maintained, I switched to
react-helmet-asyncand looks like everyone is doing the same.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already added in my development plan, soon I will be switched to react-helmet-async. Thanks @maxmalov & @rifaidev for quick response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched today - it's fairly simple for a client-side rendered React project, you just have to add the provider and then replace all imports and that's pretty much it.