Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #29 - Incorrect escaping of < > #30

Merged
merged 2 commits into from
Apr 27, 2016

Conversation

buholzer
Copy link
Contributor

Pull request for issue #29 - By changing the priority of the replace statements the incorrect escaping can be prevented.

@nfarina
Copy link
Owner

nfarina commented Apr 26, 2016

Thanks so much for finding and fixing this!

I just added full test coverage to xmldoc. Would you mind pulling from master and adding a test case for this bug, then updating this PR?

@buholzer
Copy link
Contributor Author

Just added the test, let me know if you need anything else.

@nfarina
Copy link
Owner

nfarina commented Apr 27, 2016

Awesome, thanks again!

@nfarina nfarina merged commit cff8451 into nfarina:master Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants