Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update set annotations usage #202

Merged
merged 15 commits into from
Dec 4, 2024
Merged

Update set annotations usage #202

merged 15 commits into from
Dec 4, 2024

Conversation

anngvu
Copy link
Contributor

@anngvu anngvu commented Nov 15, 2024

Close #199 and adds vignette. Let's merge this first, and then #186 will rebase to take advantage of it. This makes the necessary changes in:

While #186 makes changes in:

  • R/basic_utils.R
  • R/datasets.R
  • R/find.R
  • R/nextflow_annotation_utils.R
  • R/provenance.R

@allaway allaway self-assigned this Nov 15, 2024
@aditya-nath-sage
Copy link

Happy to test it

@allaway allaway assigned aditya-nath-sage and unassigned allaway Nov 15, 2024
@anngvu anngvu linked an issue Nov 15, 2024 that may be closed by this pull request
@anngvu anngvu removed a link to an issue Nov 15, 2024
@aditya-nath-sage
Copy link

here is the manifest generated: https://docs.google.com/spreadsheets/d/1P4AyJyzafDRCq3sUclUdKt83mTAJIvzZPNvLKswGqU8/edit?gid=0#gid=0

Seems like most fields are still missing?

@anngvu
Copy link
Contributor Author

anngvu commented Nov 28, 2024

@aditya-nath-sage Use the other id: syn53975003

image

@anngvu
Copy link
Contributor Author

anngvu commented Dec 4, 2024

@aditya-nath-sage Reminder to 1) run through vignettes/annotate-data-intro.Rmd and 2) test annotate_with_manifest(manifest) as part of the Jira ticket NFINT-950

@aditya-nath-sage
Copy link

manifest_generate test with syn53975003 :https://docs.google.com/spreadsheets/d/1A17I4pJ9zmwf-0t1zDjVu_Ns9x20GS7ZoPL-R0EIjhk/edit?gid=0#gid=0

Seems to populate well!

@aditya-nath-sage
Copy link

aditya-nath-sage commented Dec 4, 2024

Set annotations for dev project (syn26462036) and then created manifest:
Looks to have added annotations to a row!
https://docs.google.com/spreadsheets/d/1OrWpemuxs0unu2OOd23kbN5tEZyvxTXt3m1lv_8RlU8/edit?gid=0#gid=0

@anngvu
Copy link
Contributor Author

anngvu commented Dec 4, 2024

@aditya-nath-sage Great! Thanks, this seems good enough validation that R and these package functions are clear and can be applied by you for test scenarios as well as real scenarios.

Let me know if you have any questions on "how do I use this?" or "this seems to not be working for me", otherwise you can submit review approval.

@anngvu anngvu merged commit f99e509 into develop Dec 4, 2024
6 of 7 checks passed
@anngvu anngvu mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated getAnnotations/setAnnotations usage to help update to Python client >= v4.3.1
3 participants