Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch tests, schematic update with 'typing_extensions' bug workaround, add bmp format #421

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

anngvu
Copy link
Collaborator

@anngvu anngvu commented Apr 11, 2024

Fix broken tests (#416) and make sure to use latest version of schematic (#422). Add needed term to trigger tests, assess fix.

Copy link

github-actions bot commented Apr 11, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://nf-osi.github.io/nf-metadata-dictionary/pr-preview/pr-421/
on branch gh-pages at 2024-04-11 15:11 UTC

@anngvu anngvu changed the title Patch/tests Patch tests, add bmp format Apr 11, 2024
Copy link

github-actions bot commented Apr 11, 2024

Test Suite Report

Template Generation

template result link
AnimalIndividualTemplate 😄 template link
BiospecimenTemplate 😄 template link
ClinicalAssayTemplate 😄 template link
EpigeneticsAssayTemplate 😄 template link
FlowCytometryTemplate 😄 template link
GenomicsAssayTemplate 😄 template link
GenomicsAssayTemplateExtended 😄 template link
HumanCohortTemplate 😄 template link
ImagingAssayTemplate 😄 template link
LightScatteringAssayTemplate 😄 template link
MethylationArrayTemplate 😄 template link
MRIAssayTemplate 😄 template link
PharmacokineticsAssayTemplate 😄 template link
PlateBasedReporterAssayTemplate 😄 template link
ProcessedAlignedReadsTemplate 😄 template link
ProcessedExpressionTemplate 😄 template link
ProcessedVariantCallsTemplate 😄 template link
ProteomicsAssayTemplate 😄 template link
ProtocolTemplate 😄 template link
RNASeqTemplate 😄 template link
ScRNASeqTemplate 😄 template link
UpdateMilestoneReport 😄 template link
WESTemplate 😄 template link
WGSTemplate 😄 template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv Conditional validation for attributes is currently not supported
ScRNASeqTemplate_0.csv Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv 😄 Fail because of missing data in required field libraryStrand

@anngvu anngvu merged commit 325b932 into main Apr 11, 2024
@anngvu anngvu deleted the patch/tests branch April 11, 2024 16:09
This was linked to issues Apr 11, 2024
@anngvu anngvu changed the title Patch tests, add bmp format Patch tests, schematic update, add bmp format Apr 26, 2024
@anngvu anngvu changed the title Patch tests, schematic update, add bmp format Patch tests, schematic update with 'typing_extensions' bug workaround, add bmp format May 30, 2024
@anngvu anngvu mentioned this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to schematic 24.2.1 from 24.1.1 broken tests
2 participants