adding some user friendly declarations! #15
Conversation
|
Just checking, are you still working on this or waiting on review? |
|
Waiting on review on this one... working on a different branch for the next part of this module |
| box(title = "Positional information of variants in tumor samples", | ||
| status = "primary", solidHeader = TRUE, | ||
| width = 1000, | ||
| collapsible = FALSE, | ||
| plotOutput(ns('lollipop_plot')) | ||
| ) | ||
| plotOutput(ns('lollipop_plot'))) |
There was a problem hiding this comment.
I get this error: "argument "p" is missing, with no default" with the full cohort selected.
There was a problem hiding this comment.
hmmm... I am not getting that error message on my end.
In previous iterations, I got this error when the cohort excluded all samples with genomic var data and the plotting dataset consisted of 0 samples. But in this case the new user messages should take care of this scenario.
There was a problem hiding this comment.
I found the root of this bug: PoisonAlien/maftools#387
There was a problem hiding this comment.
awesome!
also, I was able to reproduce the bug on my end when I pulled the develop branch today. On the gene_var_1 branch its works well but not on the develop :) possibly due to the issue you mentioned above :)
There was a problem hiding this comment.
Re-opening this conversation since this bug is now bugging me! :(
There was a problem hiding this comment.
To clarify my not-so-clear remark earlier: Acc to issue 387, the issue of maftools layout being overwritten by plotly was fixed in the latest version. But even with the latest version pulled from github, I am encountering this bug when I run the app locally. I reported this observation to PoisonAlien.
|
I can't reproduce this bug on my computer at work....so I guess I was doing something weird, or pulled the wrong branch again. so, LGTM! |
No description provided.