Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #812

Merged
merged 2 commits into from
Dec 10, 2020
Merged

fix typo #812

merged 2 commits into from
Dec 10, 2020

Conversation

subwaystation
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

This PR fixes #811

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
ryelle Kelly Dwan
@subwaystation subwaystation requested a review from ewels December 10, 2020 09:03
@github-actions
Copy link
Contributor

Hi @subwaystation,

It looks like this pull-request has been made against the nf-core/tools master branch. The master branch on nf-core repositories should always contain code from the latest release. Because of this, PRs to master are only allowed if they come from the nf-core/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.

Thanks again for your contribution!

@subwaystation subwaystation requested a review from jfy133 December 10, 2020 09:03
@subwaystation subwaystation changed the base branch from master to dev December 10, 2020 09:03
@jfy133
Copy link
Member

jfy133 commented Dec 10, 2020

I put the . as it makes it a complete command because python requires that the location is specified. Maybe with replace <PIPELINE PATH> or similar instead

@subwaystation
Copy link
Contributor Author

Oh. I didn't realize that. So maybe there is only a . missing at the end of the sentence? I am fine with the . as you had it before. I just thought it is a typo. Sorry.

@jfy133
Copy link
Member

jfy133 commented Dec 10, 2020

Correct, missing full-stop at the end of the sentence should be added (so inaddition to the command itself)!

…b/CONTRIBUTING.md


Thanks @apeltzer!

Co-authored-by: Alexander Peltzer <apeltzer@users.noreply.github.com>
subwaystation added a commit to nf-core/pangenome that referenced this pull request Dec 10, 2020
Zethson added a commit to nf-core/pangenome that referenced this pull request Dec 10, 2020
@jfy133 jfy133 merged commit 4a11490 into dev Dec 10, 2020
@ewels ewels deleted the issue811 branch February 14, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typo in template file CONTRIBUTING.md
3 participants