Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module import #615

Merged
merged 18 commits into from
Jul 13, 2020
Merged

Module import #615

merged 18 commits into from
Jul 13, 2020

Conversation

ewels
Copy link
Member

@ewels ewels commented Jun 2, 2020

Continuation of #579 so that more people can contribute.


Proof-of-concept pull request for building a simplistic import system tools from nf-core/modules into pipelines.

See nf-core/modules#8 for (extensive) discussion.

Current functionality:

$ nf-core modules --help


                                          ,--./,-.
          ___     __   __   __   ___     /,-._.--~\
    |\ | |__  __ /  ` /  \ |__) |__         }  {
    | \| |       \__, \__/ |  \ |___     \`-._,-`-,
                                          `._,._,'

    nf-core/tools version 1.10.dev0

Usage: nf-core modules [OPTIONS] COMMAND [ARGS]...

  Manage DSL 2 module imports

Options:
  -r, --repository TEXT  GitHub repository name.
  -b, --branch TEXT      The git branch to use.
  --help                 Show this message and exit.

Commands:
  list     List available tools
  install  Install a DSL2 module
  update   Update one or all DSL2 modules
  remove   Remove a DSL2 module
  check    Check that imported module code has not been modified
  fix      Replace imported module code with a freshly downloaded copy
$ nf-core modules list

                                          ,--./,-.
          ___     __   __   __   ___     /,-._.--~\
    |\ | |__  __ /  ` /  \ |__) |__         }  {
    | \| |       \__, \__/ |  \ |___     \`-._,-`-,
                                          `._,._,'

    nf-core/tools version 1.10.dev0


INFO: Tools available from nf-core/modules (master):

bwa
cutadapt
fastqc
gatk
htslib
samtools
trim_galore
$  nf-core modules install fastqc

                                          ,--./,-.
          ___     __   __   __   ___     /,-._.--~\
    |\ | |__  __ /  ` /  \ |__) |__         }  {
    | \| |       \__, \__/ |  \ |___     \`-._,-`-,
                                          `._,._,'

$ ls modules/tools/fastqc/
main.nf   meta.yml  test/

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #615 into dev will increase coverage by 0.19%.
The diff coverage is 80.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #615      +/-   ##
==========================================
+ Coverage   76.49%   76.69%   +0.19%     
==========================================
  Files          12       13       +1     
  Lines        2463     2617     +154     
==========================================
+ Hits         1884     2007     +123     
- Misses        579      610      +31     
Impacted Files Coverage Δ
nf_core/__main__.py 65.16% <66.10%> (-0.27%) ⬇️
nf_core/modules.py 88.77% <88.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eeae29...b12a82e. Read the comment docs.

@ewels ewels marked this pull request as draft June 2, 2020 16:31
@ewels ewels added the WIP Work in progress label Jun 2, 2020
ewels added 3 commits July 13, 2020 10:08
* Pass pipeline directory as an argument
* Don't copy test directory to  pipeline
@ewels ewels marked this pull request as ready for review July 13, 2020 09:05
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM! Happy for a merge so we can get testing with it all 👍

@ewels ewels merged commit 5f03a4d into dev Jul 13, 2020
@ewels ewels deleted the module-import branch July 13, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants