Fix number of arguments for pipelines_create within the command_create function #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirpedrol
requested changes
Jul 18, 2024
nf_core/__main__.py
Outdated
| @@ -2181,14 +2181,14 @@ def command_lint( | |||
| help="The name of the GitHub organisation where the pipeline will be hosted (default: nf-core)", | |||
| ) | |||
| @click.pass_context | |||
| def command_create(ctx, name, description, author, version, force, outdir, template_yaml, plain, organisation): | |||
| def command_create(ctx, name, description, author, version, force, outdir, template_yaml, organisation): | |||
There was a problem hiding this comment.
We shouldn't remove the argument from this function, this makes the command to fail, you can test it by running nf-core create
There was a problem hiding this comment.
Also saw that we should give a default to the version, as we do with nf-core pipelines create
mirpedrol
approved these changes
Jul 18, 2024
Co-authored-by: Júlia Mir Pedrol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3068