Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template: Run awsfulltest on PRs to master with two PR approvals #3042

Merged
merged 7 commits into from
Jul 9, 2024
Merged

Template: Run awsfulltest on PRs to master with two PR approvals #3042

merged 7 commits into from
Jul 9, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Jun 28, 2024 •
edited
Loading

Once we have this, we should set them up as branch protection rules on all master branches

edmundmiller
edmundmiller approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

To clarify, it'll run twice, once on the PR review and then once when the PR is merged?

@mashehu
Copy link
Contributor Author

mashehu commented Jun 29, 2024 •
edited
Loading

Nope, the aws launch step should only run after two approvals

@mashehu mashehu enabled auto-merge July 9, 2024 05:42
@mashehu mashehu merged commit ecfe0fb into nf-core:dev Jul 9, 2024
34 checks passed
@mashehu mashehu deleted the run-aws-fulltest-only-after-two-reviews branch July 9, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundmiller edmundmiller edmundmiller approved these changes

@FriederikeHanssen FriederikeHanssen Awaiting requested review from FriederikeHanssen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mashehu @edmundmiller @nf-core-bot