-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no clobber and put bash options on their own line #2991
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'd rather have someone else look at this too since I'm not that familiar with this
Hi @mahesh-panchal, do you have a link to docs about the |
Thanks! Could this break any existing pipelines which might be using this redirection? |
I'm not aware of any modules that are purposely overwriting files. We normally add checks to prevent that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for double checking, looks good to me then 🙂
PR checklist
CHANGELOG.md
is updateddocs
is updated