-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to dynamically insert tool citations into MultiQC report #2326
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2326 +/- ##
=======================================
Coverage 72.86% 72.86%
=======================================
Files 78 78
Lines 8774 8774
=======================================
Hits 6393 6393
Misses 2381 2381 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very nice!
I wonder if we could parse a file such as CITATIONS.md given that we already have it (or a JSON/YAML version of it) instead of having the developer manually add the citations in the groovy script. I'm sure I'm not the first one to consider this, and there might be some challenges in implementing it 😄 Anyway, this looks like a good start! 🚀
CHANGELOG.md
Outdated
@@ -19,6 +19,7 @@ | |||
- Add `singularity.registry = 'quay.io'` in pipeline template | |||
- Bump minimum required NF version in pipeline template from `22.10.1` -> `23.04.0` | |||
- Add ability to interpret `docker.registry` from `nextflow.config` file. If not found defaults to quay.io. ([#2318](https://github.com/nf-core/tools/pull/2318)) | |||
- Add functions to dynamically include pipeline tool citations in MultiQC methods description section for better reporting. ([#XXXX](XXXX)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add link to this PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops thanks!
What @maxulysse and I have talked about is in teh future is actually taking somehow the DOI from meta.yml ( What I was actually thinking was (in the future!) if we should embed the DOI within the process itself (as well as the version) as specific |
Taking the doi from the meta.yml sounds totally doable to me (and all should be even of the same formatting thanks to the schema). Just need to have it flexible enough to handle modules without DOIs. |
How would we filter for just modules that ran though? |
I imagine to do it similar to how we do software versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job! ❤️
I agree that parsing the DOIs of the executed modules from the yml
will be a very nice addition.
Extends the methods description in the MultiQC report to optionally generate text dynamically depending on what steps in the pipeline are run, to include citations/references of the tools used in the given pipeline run.
This hopefully will improve method reporting and credit to all the authors of the tools used in pipelines, as it more actively shows citation information of these tools over
citations.md
ormeta.yaml
, neither of which are exposed to users. It also makes it easier for users to report these as the pipeline author can make the text only have references of tools used in the run, so the user does not have to scroll through 10s of bibliographic references incitations.md
to find the ones of the tools they actually used.Real life proof of concept can be seen here: nf-core/taxprofiler#308
Things to consider:
meta.yml
but we have no way to parse these (let alone dynamically depending on which tool used)However I believe this is a good starting point that overtime could be more automated in future template updates, as it at least provides a place/mechanism to include in the report (regardless of how the text is generated).
Partly addresses #236
PR checklist
CHANGELOG.md
is updateddocs
is updated