Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Taxpasta to v0.6.0 #368

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Update Taxpasta to v0.6.0 #368

merged 5 commits into from
Sep 11, 2023

Conversation

LilyAnderssonLee
Copy link
Contributor

@LilyAnderssonLee LilyAnderssonLee commented Sep 11, 2023 •
edited
Loading

Update TAXPASTA to the latest version, v0.6.0, which enables error handling for empty profiles when executing taxpasta merge.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/taxprofiler branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Sep 11, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 9d030a8

+| ✅ 156 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.1.0
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-11 17:04:42

jfy133
jfy133 approved these changes Sep 11, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@LilyAnderssonLee @jfy133
Update CHANGELOG.md
3081538 
Co-authored-by: James A. Fellows Yates <[email protected]>
Midnighter
Midnighter reviewed Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@Midnighter Midnighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some recommended wording changes.

nextflow_schema.json Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
LilyAnderssonLee and others added 2 commits September 11, 2023 19:02
@LilyAnderssonLee @Midnighter
Update CHANGELOG.md
5382789 
Co-authored-by: Moritz E. Beber <[email protected]>
@LilyAnderssonLee @Midnighter
Update nextflow_schema.json
9d030a8 
Co-authored-by: Moritz E. Beber <[email protected]>
@LilyAnderssonLee LilyAnderssonLee merged commit 3fee7d5 into nf-core:dev Sep 11, 2023
26 checks passed
@LilyAnderssonLee LilyAnderssonLee deleted the new_taxpasta branch October 3, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Midnighter Midnighter Midnighter left review comments

@jfy133 jfy133 jfy133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LilyAnderssonLee @Midnighter @jfy133