Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gzip error #382

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Fix gzip error #382

wants to merge 3 commits into from

Conversation

esrice
Copy link

@esrice esrice commented Oct 11, 2024

Fix #380 --- when giving an un-gzipped whitelist file to the pipeline, both STAR and alevin-fry crash. These two commits fix those two issues, respectively, so that both gzipped and un-gzipped whitelists are allowed.

grst and others added 3 commits August 15, 2024 08:25
The alevin-fry workflow for this pipeline has the same issue as the STAR
workflow: it assumes the whitelist is gzipped, and crashes if it is not.
This commit fixes that by only trying to unzip the whitelist if it is in
fact gzipped.
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @esrice,

It looks like this pull-request is has been made against the esrice/scrnaseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the esrice/scrnaseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@esrice esrice changed the base branch from master to dev October 11, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashes due to trying to unzip file that is not zipped
2 participants