Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 263 #267

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Fix 263 #267

merged 3 commits into from
Sep 22, 2023

Conversation

grst
Copy link
Member

@grst grst commented Sep 21, 2023 •
edited
Loading

Fixes #263

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/scrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@grst
Copy link
Member Author

grst commented Sep 21, 2023

@FelixKrueger, could you please give this a try?

@github-actions
Copy link

github-actions bot commented Sep 21, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit dad9d8f

+| ✅ 155 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-22 10:12:04

fmalmeida
fmalmeida approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@fmalmeida fmalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and clean.

@grst grst enabled auto-merge September 22, 2023 10:10
@grst grst merged commit da9b375 into dev Sep 22, 2023
14 checks passed
@grst grst deleted the fix-263 branch September 22, 2023 10:12
@FelixKrueger
Copy link

I can confirm that whitelist logic fix works on our data for a test run, will be good to integrate this into main for the next release. Cheers!

@grst
Copy link
Member Author

grst commented Oct 17, 2023

Should already be in 2.4.1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmalmeida fmalmeida fmalmeida approved these changes

@FelixKrueger FelixKrueger Awaiting requested review from FelixKrueger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grst @FelixKrueger @fmalmeida