Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASCAT exome/targeted sequencing resource file generation #981

Merged
merged 9 commits into from
Mar 29, 2023
Merged

ASCAT exome/targeted sequencing resource file generation #981

merged 9 commits into from
Mar 29, 2023

Conversation

ameynert
Copy link
Contributor

Added instructions to generate resource files for running ASCAT on exome or targeted sequencing data. Tested resulting files on TWIST exome capture kit targets and a set of 74 tumour-normal pairs.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Mar 28, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 1ab65eb

+| ✅ 152 tests passed       |+
#| ❔   8 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-03-29 08:18:16

@FriederikeHanssen
Copy link
Contributor

❤️ Loooooooove it! Thank you so much! I am not going to reproduce this, but it looks great!

@FriederikeHanssen
Copy link
Contributor

Can you update the changelog?

ameynert added 2 commits March 28, 2023 16:19
Merge pull request #1 from nf-core/dev
11dbc19 
Merge from dev into forked dev
nf-core#981
7cf0c1f
@ameynert
Copy link
Contributor Author

Can you update the changelog?

Done!

@SusiJo
Copy link
Contributor

SusiJo commented Mar 28, 2023

Hi @ameynert, don't forget to add yourself to the contributors in the Readme :)

lassefolkersen
lassefolkersen requested changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@lassefolkersen lassefolkersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Very useful 😄
One comment about the now expanded sarek/usage.md section on ASCAT usage: It seems like it's skipping on any mention of whole-genome sequencing. As I recall, that is possible out-of-the-box. Or not, I'm unsure. But regardless, it feels like if there is a long and detailed point about ASCAT exome data, then there should at least be a sentence saying what to do with ASCAT whole genome data, even if that sentence is just "it works out of the box":

@ameynert
Copy link
Contributor Author

Nice work. Very useful 😄 One comment about the now expanded sarek/usage.md section on ASCAT usage: It seems like it's skipping on any mention of whole-genome sequencing. As I recall, that is possible out-of-the-box. Or not, I'm unsure. But regardless, it feels like if there is a long and detailed point about ASCAT exome data, then there should at least be a sentence saying what to do with ASCAT whole genome data, even if that sentence is just "it works out of the box":

Good shout. I've added a sentence at the start of that section to clarify.

lassefolkersen
lassefolkersen approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@lassefolkersen lassefolkersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ameynert ameynert merged commit 56a8de5 into nf-core:dev Mar 29, 2023
@FriederikeHanssen
Copy link
Contributor

😱 what is going on with all the failing tests

@FriederikeHanssen FriederikeHanssen mentioned this pull request Mar 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lassefolkersen lassefolkersen lassefolkersen approved these changes

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@maxulysse maxulysse Awaiting requested review from maxulysse maxulysse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ameynert @FriederikeHanssen @SusiJo @lassefolkersen