Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full size test NA12878 #604

Merged
merged 7 commits into from
Jun 30, 2022
Merged

Add full size test NA12878 #604

merged 7 commits into from
Jun 30, 2022

Conversation

ggabernet
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ggabernet ggabernet marked this pull request as ready for review June 24, 2022 07:43
@ggabernet ggabernet requested a review from maxulysse as a code owner June 24, 2022 07:43
@github-actions
Copy link

github-actions bot commented Jun 24, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit bc4bebe

+| ✅ 145 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-06-28 08:15:42

maxulysse
maxulysse reviewed Jun 24, 2022
View reviewed changes
conf/test_full.config Outdated Show resolved Hide resolved
FriederikeHanssen
FriederikeHanssen reviewed Jun 27, 2022
View reviewed changes
conf/test_full.config Outdated
@@ -18,7 +18,7 @@ params {
input = '${projectDir}/tests/csv/3.0/test_full_data.csv'

// Other params
tools = 'strelka,freebayes,haplotypecaller,vep'
tools = 'strelka,freebayes,haplotypecaller,deepvariant,manta,tiddit,ascat,snpeff,vep'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASCAT only works for paired samples at the moment., cnvkit however is also implemented for germline only mode

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to do annotation? The containers are huge

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well it's a full test so it shouldn't matter much, but maybe just VEP for now then

@ggabernet ggabernet merged commit 105d5ad into nf-core:dev Jun 30, 2022
@FriederikeHanssen FriederikeHanssen mentioned this pull request Jul 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggabernet @maxulysse @FriederikeHanssen