Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added somatic cnvkit #540

Merged
merged 13 commits into from
Jun 1, 2022
Merged

Added somatic cnvkit #540

merged 13 commits into from
Jun 1, 2022

Conversation

SusiJo
Copy link
Contributor

@SusiJo SusiJo commented May 6, 2022

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link
Contributor

@lassefolkersen lassefolkersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SusiJo nice work! I couldn't get it to run in full, I mean the whole Sarek from fastq with this commit, but that's because I'm a little behind on having a test-bench for the latest of the latest. I'll work with that over the next few days. But don't let that hold you back, I think this somatic setup is absolutely what is needed and as far as I can tell from the code it looks solid what you've made.

@SusiJo SusiJo marked this pull request as ready for review May 25, 2022 07:32
@SusiJo SusiJo requested a review from maxulysse as a code owner May 25, 2022 07:32
@SusiJo
Copy link
Contributor Author

SusiJo commented May 30, 2022

I adjusted the order in the modules.config and moved the cnvkit-tumoronly stuff to the tumor-variant-calling section

conf/modules.config Show resolved Hide resolved
@FriederikeHanssen FriederikeHanssen merged commit c60ef1f into nf-core:dev Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants