Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sarek to 3.0dev #333

Merged
merged 18 commits into from
Jan 26, 2021
Merged

Bump sarek to 3.0dev #333

merged 18 commits into from
Jan 26, 2021

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@@ -9,7 +9,7 @@ COPY environment.yml /
RUN conda env create -f /environment.yml && conda clean -a

# Add conda installation dir to PATH (instead of doing 'conda activate')
ENV PATH /opt/conda/envs/nf-core-sarek-snpeff-2.7dev/bin:$PATH
ENV PATH /opt/conda/envs/nf-core-sarek-snpeff-dev/bin:$PATH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not snpeff-3.0dev?

Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just the question of whether it should be labeled dev or 3.0dev everywhere. I don't have a preference either way

@maxulysse maxulysse merged commit 13def96 into nf-core:dev Jan 26, 2021
@maxulysse
Copy link
Member Author

Looks good. Just the question of whether it should be labeled dev or 3.0dev everywhere. I don't have a preference either way

Merged before reading comments 🤦

We can always fix that later...

@FriederikeHanssen
Copy link
Contributor

Ah no worries. It's a tiny thing about consistency. won't change anything in whether it runs or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants