Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add troubleshooting section to docs with an entry on Spark issues #294

Merged
merged 6 commits into from
Oct 20, 2020

Conversation

jfnavarro
Copy link
Contributor

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • Documentation in docs is updated

Learn more about contributing: CONTRIBUTING.md

docs/README.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@jfnavarro jfnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

docs/usage.md Outdated

### Spark related issues

If you have problems running processes that make use of Spark such as ```MarkDuplicates```.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you have problems running processes that make use of Spark such as ```MarkDuplicates```.
If you have problems running processes that make use of Spark such as ```MarkDuplicates```.

docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated

```bash
* soft nofile 65535
* hard nofile 65535
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* hard nofile 65535
* hard nofile 65535

docs/usage.md Outdated
OPTIONS=”—default-ulimit nofile=65535:65535"
```

Re-start your session.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Re-start your session.
Re-start your session.

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good with markdownlint now.

Thanks @jfnavarro for the PR.

That's exactly what I had in mind.

@maxulysse maxulysse merged commit cce883e into nf-core:dev Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants