Add Subworkflow Build_Indices for switch to DSL2 #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FriederikeHanssen
changed the title
|
The simple test does not pass now any more |
|
yay! test |
ggabernet
approved these changes
Jul 15, 2020
There was a problem hiding this comment.
Looks good to me! Indices are being built :) Maybe let's let @maxulysse have a look if he's fine with it?
maxulysse
reviewed
Jul 15, 2020
| ## [dsl2](https://github.com/nf-core/sarek/tree/dev) | ||
|
|
||
| - [#238](https://github.com/nf-core/sarek/pull/238) -Add subworkflow for building all the indices | ||
|
|
||
| ## [dev](https://github.com/nf-core/sarek/tree/dev) | ||
|
|
||
| - [#234](https://github.com/nf-core/sarek/pull/234) -Switching to DSL2 |
There was a problem hiding this comment.
Maybe move this line to DSL2 too, no?
There was a problem hiding this comment.
will do in the next PR coming :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add subworklow for building indices
nf-core/sarek pull request
Many thanks for contributing to nf-core/sarek!
Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: CONTRIBUTING.md