-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Important! Template update for nf-core/tools v3.1.0 #1747
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,14 +8,14 @@ These are the most common things requested on pull requests (PRs). | |
|
||
Remember that PRs should be made against the dev branch, unless you're preparing a pipeline release. | ||
|
||
Learn more about contributing: [CONTRIBUTING.md](https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md) | ||
Learn more about contributing: [CONTRIBUTING.md](https://github.com/nf-core/sarek/tree/main/.github/CONTRIBUTING.md) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So if we only mention There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is now master because the default branch was master, once you change There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. actually, sorry, this was not true, the default branch is automatically detected from the git configuration :) |
||
--> | ||
|
||
## PR checklist | ||
|
||
- [ ] This comment contains a description of changes (with reason). | ||
- [ ] If you've fixed a bug or added code that should be tested, add tests! | ||
- [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md) | ||
- [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/sarek/tree/main/.github/CONTRIBUTING.md) | ||
- [ ] If necessary, also make a PR on the nf-core/sarek _branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository. | ||
- [ ] Make sure your code lints (`nf-core pipelines lint`). | ||
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker --outdir <OUTDIR>`). | ||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -6,12 +6,5 @@ tasks: | |||||
nextflow self-update | ||||||
|
||||||
vscode: | ||||||
extensions: # based on nf-core.nf-core-extensionpack | ||||||
#- esbenp.prettier-vscode # Markdown/CommonMark linting and style checking for Visual Studio Code | ||||||
- EditorConfig.EditorConfig # override user/workspace settings with settings found in .editorconfig files | ||||||
- Gruntfuggly.todo-tree # Display TODO and FIXME in a tree view in the activity bar | ||||||
- mechatroner.rainbow-csv # Highlight columns in csv files in different colors | ||||||
- nextflow.nextflow # Nextflow syntax highlighting | ||||||
- oderwat.indent-rainbow # Highlight indentation level | ||||||
- streetsidesoftware.code-spell-checker # Spelling checker for source code | ||||||
- charliermarsh.ruff # Code linter Ruff | ||||||
extensions: | ||||||
#- nf-core.nf-core-extensionpack # https://github.com/nf-core/vscode-extensionpack | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A fix for this is added to the template now
Suggested change
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
{ | ||
"markdown.styles": ["public/vscode_markdown.css"], | ||
"nextflow.formatting.harshilAlignment": true | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"$schema": "https://json-schema.org/draft/2020-12/schema", | ||
"$id": "https://raw.githubusercontent.com/nf-core/sarek/master/assets/schema_input.json", | ||
"$id": "https://raw.githubusercontent.com/nf-core/sarek/main/assets/schema_input.json", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So if we only mention |
||
"title": "nf-core/sarek pipeline - params.input schema", | ||
"description": "Schema for the file provided with params.input", | ||
"type": "array", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mirpedrol ok, so I don't think we need to mention master here if we move all to main in all other locations already