Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sentieon #1746

Merged
merged 5 commits into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [1712](https://github.com/nf-core/sarek/pull/1712) - Fix missing import statements on error messages when starting without samplesheet
- [1743](https://github.com/nf-core/sarek/pull/1743) - Add setup java 17 in GHA for latest Nextflow version
- [1745](https://github.com/nf-core/sarek/pull/1745) - Fix bug where workflow can hang if the email parameter is set
- [](https://github.com/nf-core/sarek/pull/) - Fix Sentieon module inputs
FriederikeHanssen marked this conversation as resolved.
Show resolved Hide resolved

### Removed

Expand Down
3 changes: 2 additions & 1 deletion conf/modules/aligner.config
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ process {
}

withName: 'SENTIEON_BWAMEM' {
ext.prefix = { params.split_fastq > 1 ? "${meta.id}".concat('.').concat(reads.get(0).name.tokenize('.')[0]).concat('.bam') : "${meta.id}.sorted.bam" }
ext.when = { params.aligner == 'sentieon-bwamem' }
}

withName: 'BWAMEM.*_MEM|DRAGMAP_ALIGN|SENTIEON_BWAMEM' {
ext.prefix = { params.split_fastq > 1 ? "${meta.id}".concat('.').concat(reads.get(0).name.tokenize('.')[0]) : "${meta.id}.sorted" }
publishDir = [
mode: params.publish_dir_mode,
path: { "${params.outdir}/preprocessing/" },
Expand All @@ -56,6 +56,7 @@ process {
}

withName: 'BWAMEM.*_MEM|DRAGMAP_ALIGN' {
ext.prefix = { params.split_fastq > 1 ? "${meta.id}".concat('.').concat(reads.get(0).name.tokenize('.')[0]) : "${meta.id}.sorted" }
// Markduplicates Spark NEEDS name-sorted reads or runtime goes through the roof
// However if it's skipped, reads need to be coordinate-sorted
// Only name sort if Spark for Markduplicates + duplicate marking is not skipped
Expand Down
2 changes: 1 addition & 1 deletion conf/modules/sentieon_dedup.config
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
process {

withName: 'SENTIEON_DEDUP' {
ext.prefix = { "${meta.id}.dedup" }
ext.prefix = { "${meta.id}.dedup.cram" }
ext.when = { params.tools && params.tools.split(',').contains('sentieon_dedup') }
publishDir = [
[
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ workflow BAM_JOINT_CALLING_GERMLINE_SENTIEON {
.map{ meta, gvcf, tbi, intervals -> [ [ id:'joint_variant_calling', intervals_name:intervals.baseName, num_intervals:meta.num_intervals ], gvcf, tbi, intervals ] }
.groupTuple(by:[0, 3])

SENTIEON_GVCFTYPER(sentieon_input, fasta.map{meta, it -> [ it ]}, fai.map{meta, it -> [ it ]}, dbsnp, dbsnp_tbi)
SENTIEON_GVCFTYPER(sentieon_input, fasta, fai, dbsnp, dbsnp_tbi)

BCFTOOLS_SORT(SENTIEON_GVCFTYPER.out.vcf_gz)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ workflow BAM_VARIANT_CALLING_SENTIEON_HAPLOTYPER {
emit_vcf = lst.size() > 0 ? lst[0] : ''

SENTIEON_HAPLOTYPER(
cram_intervals_for_sentieon,
fasta.map{ meta, it -> it },
fasta_fai.map{ meta, it -> it },
cram_intervals_for_sentieon.map{ meta, cram, crai, intervals, num_intervals -> [ meta, cram, crai, intervals, [] ]},
fasta,
fasta_fai,
dbsnp,
dbsnp_tbi,
emit_vcf,
Expand Down
Loading