Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #1151

Merged
merged 22 commits into from
Jul 12, 2023
Merged

Refactor #1151

merged 22 commits into from
Jul 12, 2023

Conversation

FriederikeHanssen
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@maxulysse
Copy link
Member

Replace #1150

maxulysse
maxulysse reviewed Jul 11, 2023
View reviewed changes
conf/test.config Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Jul 11, 2023
View reviewed changes
conf/test.config Outdated Show resolved Hide resolved
FriederikeHanssen
FriederikeHanssen commented Jul 11, 2023
View reviewed changes
workflows/sarek.nf Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jul 11, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit bf43387

+| ✅ 152 tests passed       |+
#| ❔   9 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-07-12 07:44:33

maxulysse
maxulysse reviewed Jul 12, 2023
View reviewed changes
conf/test.config Outdated Show resolved Hide resolved
maxulysse
maxulysse approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

asp8200
asp8200 reviewed Jul 12, 2023
View reviewed changes
conf/modules/sentieon_haplotyper.config
path: { "${params.outdir}/variant_calling/sentieon_haplotyper/${meta.id}/"},
pattern: "*{vcf.gz,vcf.gz.tbi}"
]
if (params.tools && params.tools.contains('sentieon_haplotyper')) {
Copy link
Contributor

@asp8200 asp8200 Jul 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the if-clause added to avoid the standard WARN when BAM_VARIANT_CALLING_SENTIEON_HAPLOTYPER:VCF_VARIANT_FILTERING_GATK:FILTERVARIANTTRANCHES doesn't run?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

asp8200
asp8200 reviewed Jul 12, 2023
View reviewed changes
conf/test/cache.config
@@ -63,6 +63,7 @@ process {
ext.sentieon_auth_data_base64 = secrets.SENTIEON_AUTH_DATA_BASE64
}

// This must contain .* in order to properly overwrite the standard config in test cases
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the comment 👍

asp8200
asp8200 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@asp8200 asp8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👏

@FriederikeHanssen FriederikeHanssen merged commit ebd97a9 into dev Jul 12, 2023
75 checks passed
@FriederikeHanssen FriederikeHanssen deleted the refactor branch July 12, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@asp8200 asp8200 asp8200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FriederikeHanssen @maxulysse @asp8200