Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More check for the samplesheet #950

Closed
maxulysse opened this issue Feb 23, 2023 · 4 comments
Closed

More check for the samplesheet #950

maxulysse opened this issue Feb 23, 2023 · 4 comments
Assignees
@matrulda
Labels
enhancement New feature or request input validation
Milestone
3.2

Comments

@maxulysse
Copy link
Member

Description of feature

no space in sample or id
@maxulysse maxulysse added the enhancement New feature or request label Feb 23, 2023
@maxulysse
Copy link
Member Author

We could have spaces replaced by _

@maxulysse maxulysse added this to the 3.2 milestone Feb 23, 2023
@asp8200
Copy link
Contributor

asp8200 commented Feb 23, 2023

We could have spaces replaced by _

Users could potentially be confused by such automatic changes to identifiers like sample and id. Perhaps it would be better just to enforce a policy of no spaces in sample or id, and then let the users deal with that themselves? 🤔

@maxulysse
Copy link
Member Author

good point, I'd rather have an early failure with an explicit message indeed

@matrulda matrulda self-assigned this Mar 27, 2023
@matrulda matrulda mentioned this issue Mar 28, 2023
Merged
9 tasks
matrulda added a commit to matrulda/sarek that referenced this issue Mar 28, 2023
@matrulda
Update changelog with nf-core#950
a579ed2
@matrulda
Copy link
Contributor

Fix merged in #978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matrulda matrulda

Labels
enhancement New feature or request input validation
Projects
No open projects
nf-core Hackathon March 2023
Status: Done
Milestone
3.2
Development

No branches or pull requests
4 participants
@maxulysse @matrulda @FriederikeHanssen @asp8200