Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors using Launch on website #694

Closed
sheucke opened this issue Jul 28, 2022 · 12 comments
Closed

errors using Launch on website #694

sheucke opened this issue Jul 28, 2022 · 12 comments
Labels
bug Something isn't working

Comments

@sheucke
Copy link

sheucke commented Jul 28, 2022

Description of the bug

Hi Sarek Team,

I wanted to try the new 3.0 version but run into a lot of errors doing so.

First the documentations is wrong here:

First, go to the nf-core/sarek releases page and find the latest version number - numeric only (eg. 3.0.0). Then specify this when running the pipeline with -r (one hyphen) - eg. -r 3.0.0.

It only works like with -r 3.0 otherwise I get error that 3.0.0 does not exist.

then I get errors with the launch tool:

for the --input field with: example_pair_fastq.csv

Must match pattern .csv$
Path to comma-separated file containing information about the samples in the experiment.

I did transform the tsv into a csv file, that can not be the problem.

then later for --tools: FreeBayes, HaplotypeCaller, Manta, snpEff, VEP

I get the error:

Must match pattern ^((ascat|cnvkit|controlfreec|deepvariant|freebayes|haplotypecaller|manta|merge|mpileup|msisensorpro|mutect2|snpeff|strelka|tiddit|vep),?)$

sry i cant translate that, in the help its still written comma separated, which I did.

best regards
sebastian

Command used and terminal output

No response

Relevant files

No response

System information

No response

@sheucke sheucke added the bug Something isn't working label Jul 28, 2022
@FriederikeHanssen
Copy link
Contributor

Can you post your full command line and possible your input.csv? From what you have posted:

  1. Yes revision is 3.0
  2. tools must all be lower case, comma-separated, no spaces
  3. csv file must contain a header line and end on .csv

@sheucke
Copy link
Author

sheucke commented Jul 28, 2022

Hi Friederike,

its the Launch tool which gives error by it self, it does not know my csv and at that point it should not matter if the csv file in it self is wrong. I use the launch tool to get an params.json file.

best regards
sebastian

@maxulysse
Copy link
Member

Hi @sheucke
The params validation is done right at the start.
We need to check that proper params, including the one used to specify the samplesheet have been used, and then we can start checking the csv file.

@sheucke
Copy link
Author

sheucke commented Jul 28, 2022

Hi max,
What I mean is your Launch tool https://nf-co.re/launch?pipeline=sarek&release=3.0. I f you enter any file name with .csv it will give you an error and so you will never get a params.json file.

I hope I could make it clear now. Please try the link for yourself.

Best regards
sebastian

@sheucke
Copy link
Author

sheucke commented Jul 28, 2022

error

@maxulysse
Copy link
Member

Oh I see, I finally understand what's your issue.
Yes, definitively an issue on our side, we must have messed up the pattern, sorry about that, we'll work on a fix in dev

@maxulysse maxulysse changed the title errors using Launch tool errors using Launch on website Jul 28, 2022
@sheucke
Copy link
Author

sheucke commented Jul 28, 2022

thank you. For the tools input my personal preference would be the exact tool name, as they are written in the help, but if you need everything in lowercase its ok, but i think it could also be done in background or with a more open regular expression.

I will close the issue now.

@sheucke sheucke closed this as completed Jul 28, 2022
@FriederikeHanssen
Copy link
Contributor

Hi @sheucke ! Is the launch tool now working for you?

@joshuamschmidt
Copy link

Hi @FriederikeHanssen I tried this today (sarek 3.0.2) and got the same Must match pattern \.csv$ error with a file named samplesheet.csv.
sarek_launch_error

@joshuamschmidt
Copy link

in fact, the underlying regex only matches a file named .csv:

sarek_launch_csv

@maxulysse maxulysse reopened this Oct 26, 2022
@maxulysse
Copy link
Member

Thanks for reporting the issue, I'll make sure to fix that ASAP

@FriederikeHanssen
Copy link
Contributor

Fix is now available on dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants