Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace param haplotypecaller_filter, haplotyper_filter and dnascope_filter with variant_filter #1210

Closed
asp8200 opened this issue Sep 6, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@asp8200
Copy link
Contributor

asp8200 commented Sep 6, 2023

Description of feature

No need to have three (or more) params for skipping the variant-filtering.

Replace the "options" haplotypecaller_filter, haplotyper_filter and dnascope_filter for --skip_tools with variant_filter

https://nfcore.slack.com/archives/C02MDBZAYJK/p1694010751853099

Also, add variant-filtering for mutect2.

@asp8200
Copy link
Contributor Author

asp8200 commented Sep 14, 2023

Might one want to run several variant-callers but only skip the variant-filter for some of them? Like

nextflow run nf-core/sarek <usual stuff> --tools haplotypecaller,sentieon_haplotyper --skip_tools haplotypecaller_filter

With a cmd like that the variant-filter could only be applied to the vcf from the GATK haplotypecaller and NOT to the vcf from the Sentieon Haplotyper. Do we need that kind of flexibility?

@asp8200
Copy link
Contributor Author

asp8200 commented Sep 17, 2023

Rike suggested that we keep haplotypecaller_filter, haplotyper_filter and dnascope_filter for --skip_tools as it adds some flexibility.

@asp8200 asp8200 closed this as completed Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant