Updated the Colabfold (version 1.5.2) and AlphaFold (version 2.3.2) containers #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
l-mansouri
changed the title
This was
linked to
issues
May 3, 2023
Closed
JoseEspinosa
requested changes
May 5, 2023
| @@ -40,7 +40,7 @@ workflow PREPARE_ALPHAFOLD2_DBS { | |||
| ch_mmcif_files = file( params.pdb_mmcif_path, type: 'dir' ) | |||
| ch_mmcif_obsolete = file( params.pdb_mmcif_path, type: 'file' ) | |||
| ch_mmcif = ch_mmcif_files + ch_mmcif_obsolete | |||
| ch_uniclust30 = file( params.uniclust30_path, type: 'dir' ) | |||
| ch_uniref30 = file( params.uniref30_alphafold2_path, type: 'any' ) | |||
There was a problem hiding this comment.
If my first comment is OK (the one that has been to be corroborated by @athbaltzis then this should be):
Suggested change
| ch_uniref30 = file( params.uniref30_alphafold2_path, type: 'any' ) | |
| ch_uniref30 = file( params.uniref30_alphafold2_path, type: 'dir' ) |
There was a problem hiding this comment.
I am not 100% sure of the different behaviour between the two, I can tell you that there are a bunch of files in that directory (no sub-directories)
There was a problem hiding this comment.
By the book, this should have type: 'file'. But type: 'any' would work as well.
There was a problem hiding this comment.
let me know what you guys prefer :)
There was a problem hiding this comment.
If any works we could leave it as it is 😄
Co-authored-by: Jose Espinosa-Carrasco <[email protected]>
Co-authored-by: Jose Espinosa-Carrasco <[email protected]>
|
Actually, here is the reason why library should be added see nf-core/modules#3358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).