Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge template 2.9 #111

Merged
merged 10 commits into from
Jul 11, 2023
Merged

Merge template 2.9 #111

merged 10 commits into from
Jul 11, 2023

Conversation

JoseEspinosa
Copy link
Member

Merge template 2.9

@JoseEspinosa JoseEspinosa changed the base branch from master to dev July 3, 2023 10:35
@nf-core nf-core deleted a comment from github-actions bot Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1e2b200

+| ✅ 151 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗  10 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: lib/WorkflowProteinfold.groovy
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in usage.md: Add documentation about anything specific to running your pipeline. For general topics, please point to (and add to) the main nf-core website.
  • pipeline_todos - TODO string in check_samplesheet.py: Update the script to check the samplesheet
  • pipeline_todos - TODO string in check_samplesheet.py: Update the check_samplesheet function
  • pipeline_todos - TODO string in check_samplesheet.py: Update the column names for the input samplesheet
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-07-11 10:58:03

@JoseEspinosa JoseEspinosa marked this pull request as ready for review July 3, 2023 15:42
maxulysse
maxulysse reviewed Jul 11, 2023
View reviewed changes
assets/multiqc_config.yml Outdated
@@ -1,7 +1,7 @@
report_comment: >
This report has been generated by the <a href="https://github.com/nf-core/proteinfold" target="_blank">nf-core/proteinfold</a>
This report has been generated by the <a href="https://github.com/nf-core/proteinfold/1.1.0dev" target="_blank">nf-core/proteinfold</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This report has been generated by the <a href="https://github.com/nf-core/proteinfold/1.1.0dev" target="_blank">nf-core/proteinfold</a>
This report has been generated by the <a href="https://github.com/nf-core/proteinfold" target="_blank">nf-core/proteinfold</a>

maxulysse
maxulysse requested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost perfect template merge

@JoseEspinosa
Copy link
Member Author

Will be great if you could review it @maxulysse

@maxulysse
Copy link
Member

Will be great if you could review it @maxulysse

I reviewed and asked for changes but you marked them as resolved and didn't anything about it

@JoseEspinosa
Copy link
Member Author

Your changes were applied here 3a2e413 and here ba11c1c. But the thing is not that then the file reverts to how it was currently in dev https://github.com/nf-core/proteinfold/blob/dev/assets/multiqc_config.yml ?

maxulysse
maxulysse approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoseEspinosa JoseEspinosa merged commit 3acccff into nf-core:dev Jul 11, 2023
@JoseEspinosa JoseEspinosa deleted the merge-template-2.9 branch July 11, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoseEspinosa @maxulysse @nf-core-bot