Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fixes #12 #58

Merged
merged 8 commits into from
Mar 22, 2021
Merged

This fixes #12 #58

merged 8 commits into from
Mar 22, 2021

Conversation

subwaystation
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/pangenome branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Bring the nextflow_schema.json up to date fixing #12.

@subwaystation subwaystation requested a review from Zethson March 22, 2021 17:16
@subwaystation subwaystation marked this pull request as ready for review March 22, 2021 17:16
@subwaystation subwaystation requested a review from heuermh March 22, 2021 17:24
Copy link
Contributor

@heuermh heuermh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, found a couple of minor style issues

nextflow_schema.json Outdated Show resolved Hide resolved
nextflow_schema.json Outdated Show resolved Hide resolved
@heuermh
Copy link
Contributor

heuermh commented Mar 22, 2021

Note this lint check is expected to fail

╭──────────────────────────────────────────────────────────────────────────────╮
│ [✗] 1 Test Failed                                                            │
├──────────────────────────────────────────────────────────────────────────────┤
│ conda_dockerfile: Could not find Dockerfile file string: FROM nfcore/base:1… │
╰──────────────────────────────────────────────────────────────────────────────╯

@Zethson Zethson merged commit 4e59b8f into nf-core:dev Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants