Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncronize with pggb, more testing #29

Merged
merged 6 commits into from
Dec 2, 2020

Conversation

subwaystation
Copy link
Collaborator

PR checklist

This PR is trying to solve #26.
This PR affects Dockerfile, main.nf, and nextflow.config.

@subwaystation subwaystation changed the title halfway through Syncronize with pggb, more testing Dec 2, 2020
@subwaystation subwaystation marked this pull request as ready for review December 2, 2020 16:09
@subwaystation subwaystation requested a review from Zethson December 2, 2020 16:09
@subwaystation
Copy link
Collaborator Author

subwaystation commented Dec 2, 2020

Hmm, if you take a look at https://github.com/nf-core/pangenome/pull/29/checks?check_run_id=1487357914, you can see that it does both --do_layout and --do_viz, although only one of them is specified. Any ideas why?! @Zethson

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
@subwaystation subwaystation requested a review from Zethson December 2, 2020 16:48
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@subwaystation subwaystation merged commit bf2ff4d into nf-core:dev Dec 2, 2020
subwaystation added a commit that referenced this pull request Dec 16, 2022
@github-actions
Copy link

Markdown linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install markdownlint-cli
  • Fix the markdown errors
    • Automatically: markdownlint . --config .github/markdownlint.yml --fix
    • Manually resolve anything left from markdownlint . --config .github/markdownlint.yml

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants